Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > Hi Peter, > > On 01/02/2018 13:20, Peter Xu wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pc

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Marcel Apfelbaum
On 02/02/2018 11:56, Peter Xu wrote: > On Thu, Feb 01, 2018 at 07:51:31PM +, Dr. David Alan Gilbert wrote: >> * Peter Xu (pet...@redhat.com) wrote: >>> In the past, we prioritized IOMMU migration so that we have such a >>> priority order: >>> >>> IOMMU > PCI Devices >>> >>> When migrating a

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 10:01:31PM +0200, Marcel Apfelbaum wrote: [...] > Root ports can't be nested, anyway, I suppose the migration should > follow the bus numbering order. Could I ask whether this is a must? And if yes, why? > > The question now is what happens if the migration is happenin

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Peter Xu
On Thu, Feb 01, 2018 at 07:51:31PM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pcie-root-

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-02 Thread Marcel Apfelbaum
On 02/02/2018 12:04, Peter Xu wrote: > On Thu, Feb 01, 2018 at 10:01:31PM +0200, Marcel Apfelbaum wrote: > > [...] > >> Root ports can't be nested, anyway, I suppose the migration should >> follow the bus numbering order. > > Could I ask whether this is a must? And if yes, why? > Not sure. Th

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > On 01/02/2018 21:48, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > >> On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > >>> Hi Peter, > >>> > >>> On 01/02/2018 13:20, Peter Xu wrote: > In the

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Marcel Apfelbaum
On 01/02/2018 21:48, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: >> On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: >>> Hi Peter, >>> >>> On 01/02/2018 13:20, Peter Xu wrote: In the past, we prioritized IOMMU migration so that we have such a

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > > Hi Peter, > > > > On 01/02/2018 13:20, Peter Xu wrote: > > > In the past, we prioritized IOMMU migration so that we have such a > > > priority order: > > > > > > IOMMU > PCI D

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > In the past, we prioritized IOMMU migration so that we have such a > priority order: > > IOMMU > PCI Devices > > When migrating a guest with both vIOMMU and pcie-root-port, we'll always > migrate vIOMMU first, since pcie-root-port will be seen to have t

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > Hi Peter, > > On 01/02/2018 13:20, Peter Xu wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pcie-root-port, we'll

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Michael S. Tsirkin
On Thu, Feb 01, 2018 at 02:24:15PM +0200, Marcel Apfelbaum wrote: > Hi Peter, > > On 01/02/2018 13:20, Peter Xu wrote: > > In the past, we prioritized IOMMU migration so that we have such a > > priority order: > > > > IOMMU > PCI Devices > > > > When migrating a guest with both vIOMMU and pc

[Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Peter Xu
In the past, we prioritized IOMMU migration so that we have such a priority order: IOMMU > PCI Devices When migrating a guest with both vIOMMU and pcie-root-port, we'll always migrate vIOMMU first, since pcie-root-port will be seen to have the same priority of general PCI devices. That's pro

Re: [Qemu-devel] [PATCH] pcie-root-port: let it has higher migrate priority

2018-02-01 Thread Marcel Apfelbaum
Hi Peter, On 01/02/2018 13:20, Peter Xu wrote: > In the past, we prioritized IOMMU migration so that we have such a > priority order: > > IOMMU > PCI Devices > > When migrating a guest with both vIOMMU and pcie-root-port, we'll always > migrate vIOMMU first, since pcie-root-port will be seen