Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-10 Thread Andreas Färber
Am 10.11.2011 07:33, schrieb Stefan Weil: > Am 10.11.2011 00:45, schrieb Alexander Graf: >> >> On 09.11.2011, at 13:47, Luiz Capitulino wrote: >> >>> On Wed, 09 Nov 2011 11:27:22 +0100 >>> Andreas Färber wrote: >>> Am 09.11.2011 06:58, schrieb Stefan Weil: > No. Simply remove */qmp-comman

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Stefan Weil
Am 10.11.2011 00:45, schrieb Alexander Graf: On 09.11.2011, at 13:47, Luiz Capitulino wrote: On Wed, 09 Nov 2011 11:27:22 +0100 Andreas Färber wrote: Am 09.11.2011 06:58, schrieb Stefan Weil: Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Anthony Liguori
On 11/09/2011 05:45 PM, Alexander Graf wrote: On 09.11.2011, at 13:47, Luiz Capitulino wrote: On Wed, 09 Nov 2011 11:27:22 +0100 Andreas Färber wrote: Am 09.11.2011 06:58, schrieb Stefan Weil: Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Anthony Liguori
On 11/09/2011 05:44 PM, Alexander Graf wrote: On 10.11.2011, at 00:38, Anthony Liguori wrote: On 11/09/2011 05:12 PM, Alexander Graf wrote: We have been using it that way in the past and I am not aware of a patch that removed ancient cleanups, so it's good practice to keep it working that w

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Alexander Graf
On 09.11.2011, at 13:47, Luiz Capitulino wrote: > On Wed, 09 Nov 2011 11:27:22 +0100 > Andreas Färber wrote: > >> Am 09.11.2011 06:58, schrieb Stefan Weil: >>> Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling the s390x-softmmu target. In

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Alexander Graf
On 10.11.2011, at 00:38, Anthony Liguori wrote: > On 11/09/2011 05:12 PM, Alexander Graf wrote: >> >>> We have been using it that way in the past and I am not aware of a patch >>> that removed ancient cleanups, so it's good practice to keep it working >>> that way. >>> >>> When I do a git pull

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Anthony Liguori
On 11/09/2011 05:12 PM, Alexander Graf wrote: We have been using it that way in the past and I am not aware of a patch that removed ancient cleanups, so it's good practice to keep it working that way. When I do a git pull I don't know whether or what it may bring. Always doing make clean just-

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Alexander Graf
Am 09.11.2011 um 19:01 schrieb Andreas Färber : > Am 09.11.2011 18:57, schrieb Anthony Liguori: >> On 11/09/2011 04:27 AM, Andreas Färber wrote: >>> Am 09.11.2011 06:58, schrieb Stefan Weil: Am 09.11.2011 02:38, schrieb Alexander Graf: > Commit 79627472db3 introduced breakage in compilin

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Andreas Färber
Am 09.11.2011 18:57, schrieb Anthony Liguori: > On 11/09/2011 04:27 AM, Andreas Färber wrote: >> Am 09.11.2011 06:58, schrieb Stefan Weil: >>> Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling the s390x-softmmu target. Instead of compiling, i

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Anthony Liguori
On 11/09/2011 04:27 AM, Andreas Färber wrote: Am 09.11.2011 06:58, schrieb Stefan Weil: Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling the s390x-softmmu target. Instead of compiling, it just throws a lot of errors: In file included from /dev/sh

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Luiz Capitulino
On Wed, 09 Nov 2011 11:27:22 +0100 Andreas Färber wrote: > Am 09.11.2011 06:58, schrieb Stefan Weil: > > Am 09.11.2011 02:38, schrieb Alexander Graf: > >> Commit 79627472db3 introduced breakage in compiling the s390x-softmmu > >> target. Instead of compiling, it just throws a lot of errors: > >>

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-09 Thread Andreas Färber
Am 09.11.2011 06:58, schrieb Stefan Weil: > Am 09.11.2011 02:38, schrieb Alexander Graf: >> Commit 79627472db3 introduced breakage in compiling the s390x-softmmu >> target. Instead of compiling, it just throws a lot of errors: >> >> In file included from /dev/shm/qemu/hw/pci-stub.c:24: >> ./qmp-com

Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-08 Thread Stefan Weil
Am 09.11.2011 02:38, schrieb Alexander Graf: Commit 79627472db3 introduced breakage in compiling the s390x-softmmu target. Instead of compiling, it just throws a lot of errors: In file included from /dev/shm/qemu/hw/pci-stub.c:24: ./qmp-commands.h:3: error: expected identifier or ‘(’ before ‘{’

[Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp

2011-11-08 Thread Alexander Graf
Commit 79627472db3 introduced breakage in compiling the s390x-softmmu target. Instead of compiling, it just throws a lot of errors: In file included from /dev/shm/qemu/hw/pci-stub.c:24: ./qmp-commands.h:3: error: expected identifier or ‘(’ before ‘{’ token [...] This is because we have two files