Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-11 Thread Cole Robinson
On 10/11/2013 02:19 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> Using multiple calls to error_report here means every line is >> prefaced with the (potentially long) pci-assign command line >> arguments. Use a single error_report to preserve the intended >> formatting. > > The orth

Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Markus Armbruster
Cole Robinson writes: > Using multiple calls to error_report here means every line is > prefaced with the (potentially long) pci-assign command line > arguments. Use a single error_report to preserve the intended > formatting. The orthodox way to do this is to use error_report() for the (single-

Re: [Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Alex Williamson
On Thu, 2013-10-10 at 12:58 -0400, Cole Robinson wrote: > Using multiple calls to error_report here means every line is > prefaced with the (potentially long) pci-assign command line > arguments. Use a single error_report to preserve the intended > formatting. > > Signed-off-by: Cole Robinson > -

[Qemu-devel] [PATCH] pci-assign: Fix error_report of pci-stub message

2013-10-10 Thread Cole Robinson
Using multiple calls to error_report here means every line is prefaced with the (potentially long) pci-assign command line arguments. Use a single error_report to preserve the intended formatting. Signed-off-by: Cole Robinson --- hw/i386/kvm/pci-assign.c | 34 +++---