Re: [Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

2016-05-11 Thread Peter Xu
On Wed, May 11, 2016 at 09:22:03PM -0600, Alex Williamson wrote: [...] > PCI Express to PCI/PCI-X Bridge Specification rev 1.0 > 2.3 Assignment of Requester ID and Tag by the Bridge > > PCIe-to-PCI bridges assign a requester ID composed of the secondary bus > number with devfn = 0. Although often

Re: [Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

2016-05-11 Thread Alex Williamson
On Thu, 12 May 2016 10:40:57 +0800 Peter Xu wrote: > On Wed, May 11, 2016 at 04:53:54PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 11, 2016 at 02:40:31PM +0800, Peter Xu wrote: > > > When there are devices under PCI bridge (or bridges), PCI requester ID > > > should be the one that hooked

Re: [Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

2016-05-11 Thread Peter Xu
On Wed, May 11, 2016 at 04:53:54PM +0300, Michael S. Tsirkin wrote: > On Wed, May 11, 2016 at 02:40:31PM +0800, Peter Xu wrote: > > When there are devices under PCI bridge (or bridges), PCI requester ID > > should be the one that hooked on the root PCI bus, not the PCI device > > itself. > > > > S

Re: [Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

2016-05-11 Thread Michael S. Tsirkin
On Wed, May 11, 2016 at 02:40:31PM +0800, Peter Xu wrote: > When there are devices under PCI bridge (or bridges), PCI requester ID > should be the one that hooked on the root PCI bus, not the PCI device > itself. > > Signed-off-by: Peter Xu I think this is only correct for pci bridges, and wrong

[Qemu-devel] [PATCH] pci: fix requester id to be the one on root bus

2016-05-10 Thread Peter Xu
When there are devices under PCI bridge (or bridges), PCI requester ID should be the one that hooked on the root PCI bus, not the PCI device itself. Signed-off-by: Peter Xu --- hw/pci/msi.c | 2 +- hw/pci/pci.c | 9 + include/hw/pci/pci.h | 2 ++ 3 files changed, 12 inser