Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:39, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 02:36:31PM +0200, Jan Kiszka wrote: >> On 2011-08-24 14:34, Michael S. Tsirkin wrote: >>> On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: On 2011-08-24 13:58, Michael S. Tsirkin wrote: > On Wed, Aug 24, 20

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 02:36:31PM +0200, Jan Kiszka wrote: > On 2011-08-24 14:34, Michael S. Tsirkin wrote: > > On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: > >> On 2011-08-24 13:58, Michael S. Tsirkin wrote: > >>> On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 14:34, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: >> On 2011-08-24 13:58, Michael S. Tsirkin wrote: >>> On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: On 2011-08-24 12:04, Michael S. Tsirkin wrote: > On Tue, Aug 23, 20

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 02:29:36PM +0200, Jan Kiszka wrote: > On 2011-08-24 13:58, Michael S. Tsirkin wrote: > > On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > >> On 2011-08-24 12:04, Michael S. Tsirkin wrote: > >>> On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > F

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 13:58, Michael S. Tsirkin wrote: > On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: >> On 2011-08-24 12:04, Michael S. Tsirkin wrote: >>> On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: From: Alex Williamson Nothing good can happen when we overla

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > On 2011-08-24 12:04, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > >> From: Alex Williamson > >> > >> Nothing good can happen when we overlap capabilities > >> > >> [ Jan: rebased over qemu,

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Wed, Aug 24, 2011 at 12:10:32PM +0200, Jan Kiszka wrote: > On 2011-08-24 12:04, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > >> From: Alex Williamson > >> > >> Nothing good can happen when we overlap capabilities > >> > >> [ Jan: rebased over qemu,

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Jan Kiszka
On 2011-08-24 12:04, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: >> From: Alex Williamson >> >> Nothing good can happen when we overlap capabilities >> >> [ Jan: rebased over qemu, minor formatting ] >> >> Signed-off-by: Jan Kiszka > > This doesn't bui

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > From: Alex Williamson > > Nothing good can happen when we overlap capabilities > > [ Jan: rebased over qemu, minor formatting ] > > Signed-off-by: Jan Kiszka This doesn't build for me: /scm/qemu/hw/pci.c: In function ‘pci_add_capa

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-24 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 04:59:16PM -0400, Don Dutile wrote: > So we want to pollute the dev assignment code with knowledge of this array > for bounds checking, which you're threatening to remove? OKay, I'll stop being a mule, and apply that patch. -- MST

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Don Dutile
On 08/23/2011 03:30 PM, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 22:30 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: > > On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > > > On Tue, 2011-08-23 at 21:17

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: > On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Aug 23, 2011 at 07:

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > > From: Alex Williamson > > > >

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: > On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > > From: Alex Williamson > > > > > > Nothing good can happen when we overlap capabilities > > > > > >

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Alex Williamson
On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > > From: Alex Williamson > > > > Nothing good can happen when we overlap capabilities > > > > [ Jan: rebased over qemu, minor formatting ] > > > > Signed-off-by: Jan Kiszk

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Michael S. Tsirkin
On Tue, Aug 23, 2011 at 07:28:08PM +0200, Jan Kiszka wrote: > From: Alex Williamson > > Nothing good can happen when we overlap capabilities > > [ Jan: rebased over qemu, minor formatting ] > > Signed-off-by: Jan Kiszka I'll stick an assert there instead. Normal devices don't generate overlap

[Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Jan Kiszka
From: Alex Williamson Nothing good can happen when we overlap capabilities [ Jan: rebased over qemu, minor formatting ] Signed-off-by: Jan Kiszka --- hw/pci.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6124790..ff20631 1006