[Qemu-devel] [PATCH] pci: Don't call pci_irq_handler() for a negative intx

2017-04-12 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Under some circumstances, pci_intx() can return -1 (when the interrupt pin in the config space is 0 which normally means no interrupt). I have seen cases of pci_set_irq() being called on such devices, in turn causing pci_irq_handler() to be called with "-1" as an arg

Re: [Qemu-devel] [PATCH] pci: Don't call pci_irq_handler() for a negative intx

2015-07-05 Thread Benjamin Herrenschmidt
On Sun, 2015-07-05 at 09:03 +0200, Michael S. Tsirkin wrote: > On Sun, Jul 05, 2015 at 09:28:28AM +1000, Benjamin Herrenschmidt wrote: > > Under some circumstances, pci_intx() can return -1 (when the interrupt > > pin in the config space is 0 which normally means no interrupt). > > > > I have seen

Re: [Qemu-devel] [PATCH] pci: Don't call pci_irq_handler() for a negative intx

2015-07-05 Thread Michael S. Tsirkin
On Sun, Jul 05, 2015 at 09:28:28AM +1000, Benjamin Herrenschmidt wrote: > Under some circumstances, pci_intx() can return -1 (when the interrupt > pin in the config space is 0 which normally means no interrupt). > > I have seen cases of pci_set_irq() being called on such devices, in > turn causing

[Qemu-devel] [PATCH] pci: Don't call pci_irq_handler() for a negative intx

2015-07-04 Thread Benjamin Herrenschmidt
Under some circumstances, pci_intx() can return -1 (when the interrupt pin in the config space is 0 which normally means no interrupt). I have seen cases of pci_set_irq() being called on such devices, in turn causing pci_irq_handler() to be called with "-1" as an argument which doesn't seem like a