Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 04:19:39PM -0300, Eduardo Habkost wrote: > On Tue, Aug 27, 2013 at 07:13:49PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > > > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > > > "Michael S. Ts

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Eduardo Habkost
On Tue, Aug 27, 2013 at 07:13:49PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > We have a lot of code duplication between

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > We have a lot of code duplication between machine types, >> > this increases with each new machine type >> > and each new field. >> > >> > This has already introd

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > We have a lot of code duplication between machine types, > > > this increases with each new machine type > > > and each

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Eduardo Habkost
On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > We have a lot of code duplication between machine types, > > this increases with each new machine type > > and each new field. > > > > This has already introduced a minor bug: description > > f

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 09:29:33AM +0200, Paolo Bonzini wrote: > Il 27/08/2013 09:01, Michael S. Tsirkin ha scritto: > > We have a lot of code duplication between machine types, > > this increases with each new machine type > > and each new field. > > > > This has already introduced a minor bug: d

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > We have a lot of code duplication between machine types, > this increases with each new machine type > and each new field. > > This has already introduced a minor bug: description > for pc-1.3 says "Standard PC" while description for > pc-1.4 is "Standard PC (i440FX

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Paolo Bonzini
Il 27/08/2013 09:01, Michael S. Tsirkin ha scritto: > We have a lot of code duplication between machine types, > this increases with each new machine type > and each new field. > > This has already introduced a minor bug: description > for pc-1.3 says "Standard PC" while description for > pc-1.4 i

[Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
We have a lot of code duplication between machine types, this increases with each new machine type and each new field. This has already introduced a minor bug: description for pc-1.3 says "Standard PC" while description for pc-1.4 is "Standard PC (i440FX + PIIX, 1996)" which makes you think 1.3 is