Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-09 Thread Michael S. Tsirkin
On Fri, Aug 09, 2013 at 03:26:22PM +0200, Gerd Hoffmann wrote: > On 08/09/13 14:38, Anthony Liguori wrote: > > Gerd Hoffmann writes: > > > >> On 08/08/13 18:38, Anthony Liguori wrote: > >>> This breaks migration and is unneeded with modern SeaBIOS. > >> > >> No. Dropping for piix is fine. It wi

Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-09 Thread Michael S. Tsirkin
On Fri, Aug 09, 2013 at 07:38:36AM -0500, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > On 08/08/13 18:38, Anthony Liguori wrote: > >> This breaks migration and is unneeded with modern SeaBIOS. > > > > No. Dropping for piix is fine. It will break q35 though. > > Can you elaborate? When

Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-09 Thread Gerd Hoffmann
On 08/09/13 14:38, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> On 08/08/13 18:38, Anthony Liguori wrote: >>> This breaks migration and is unneeded with modern SeaBIOS. >> >> No. Dropping for piix is fine. It will break q35 though. > > Can you elaborate? When Michael and I discussed th

Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-09 Thread Anthony Liguori
Gerd Hoffmann writes: > On 08/08/13 18:38, Anthony Liguori wrote: >> This breaks migration and is unneeded with modern SeaBIOS. > > No. Dropping for piix is fine. It will break q35 though. Can you elaborate? When Michael and I discussed this I was under the impression that latest SeaBIOS had

Re: [Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-08 Thread Gerd Hoffmann
On 08/08/13 18:38, Anthony Liguori wrote: > This breaks migration and is unneeded with modern SeaBIOS. No. Dropping for piix is fine. It will break q35 though. Given that q35 can't be migrated anyway due to ahci being tagged as unmigratable keeping it for q35 (until the new acpi table loading i

[Qemu-devel] [PATCH] pc: drop external DSDT loading

2013-08-08 Thread Anthony Liguori
This breaks migration and is unneeded with modern SeaBIOS. Signed-off-by: Anthony Liguori --- hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ab25458..daaff8a 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/