On Fri, Nov 23, 2012 at 3:15 PM, Peter Maydell wrote:
> On 23 November 2012 14:11, Stefan Hajnoczi wrote:
>> On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe
>> wrote:
>>> diff --git a/block/rbd.c b/block/rbd.c
>>> index 5a0f79f..0384c6c 100644
>>> --- a/block/rbd.c
>>> +++ b/block/rbd.c
>>> @@
Hi,
i'm not a ceph or inktank guy. I can't made any decision on what to
change. At least right now you'll see failing I/O's in your guest, when
you discard whole disks.
I could fix this for me with int64 and with ssize_t. So if i should
resend another patch i need a concrete advise how to pa
On 23 November 2012 14:11, Stefan Hajnoczi wrote:
> On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe wrote:
>> diff --git a/block/rbd.c b/block/rbd.c
>> index 5a0f79f..0384c6c 100644
>> --- a/block/rbd.c
>> +++ b/block/rbd.c
>> @@ -69,7 +69,7 @@ typedef enum {
>> typedef struct RBDAIOCB {
>>
On Thu, Nov 22, 2012 at 10:07 AM, Stefan Priebe wrote:
> diff --git a/block/rbd.c b/block/rbd.c
> index 5a0f79f..0384c6c 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -69,7 +69,7 @@ typedef enum {
> typedef struct RBDAIOCB {
> BlockDriverAIOCB common;
> QEMUBH *bh;
> -int ret;
Signed-off-by: Stefan Priebe
Am 22.11.2012 10:07, schrieb Stefan Priebe:
When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret
Look here:
if (acb->cmd == RBD_AIO_WRITE ||
acb->cmd == RBD_AIO_DISCARD) {
if (r< 0) {
acb->ret = r;
Am 22.11.2012 20:09, schrieb Stefan Priebe - Profihost AG:
Hi Andreas,
thanks for your comment. Do i have to resend this patch?
--
Greets,
Stefan
Hi Stefan,
I'm afraid yes, you'll have to resend the patch.
Signed-off-by is a must, see http://wiki.qemu.org/Contribute/SubmitAPatch
When you
Hi Andreas,
thanks for your comment. Do i have to resend this patch?
--
Greets,
Stefan
Am 22.11.2012 17:40, schrieb Andreas Färber:
Am 22.11.2012 10:07, schrieb Stefan Priebe:
When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret
Look here:
if (acb->cmd == RBD_AIO_WR
Am 22.11.2012 10:07, schrieb Stefan Priebe:
> When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret
>
> Look here:
>if (acb->cmd == RBD_AIO_WRITE ||
> acb->cmd == RBD_AIO_DISCARD) {
> if (r < 0) {
> acb->ret = r;
> acb->error = 1;
>
When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret
Look here:
if (acb->cmd == RBD_AIO_WRITE ||
acb->cmd == RBD_AIO_DISCARD) {
if (r < 0) {
acb->ret = r;
acb->error = 1;
} else if (!acb->error) {
acb->ret = rcb->
