Re: [Qemu-devel] [PATCH] osdep: Retry SETLK upon EINTR

2018-01-08 Thread Kevin Wolf
Am 26.12.2017 um 07:53 hat Fam Zheng geschrieben: > We could hit lock failure if there is a signal that makes fcntl return > -1 and errno set to EINTR. In this case we should retry. > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] osdep: Retry SETLK upon EINTR

2018-01-03 Thread Fam Zheng
On Wed, 01/03 16:57, Eric Blake wrote: > On 12/26/2017 12:53 AM, Fam Zheng wrote: > > We could hit lock failure if there is a signal that makes fcntl return > > -1 and errno set to EINTR. In this case we should retry. > > Did you hit this in practice? In 'man fcntl' on my Fedora 27 box, the > DES

Re: [Qemu-devel] [PATCH] osdep: Retry SETLK upon EINTR

2018-01-03 Thread Eric Blake
On 12/26/2017 12:53 AM, Fam Zheng wrote: > We could hit lock failure if there is a signal that makes fcntl return > -1 and errno set to EINTR. In this case we should retry. Did you hit this in practice? In 'man fcntl' on my Fedora 27 box, the DESCRIPTION section only mentions EINTR as possible fo

[Qemu-devel] [PATCH] osdep: Retry SETLK upon EINTR

2017-12-25 Thread Fam Zheng
We could hit lock failure if there is a signal that makes fcntl return -1 and errno set to EINTR. In this case we should retry. Cc: qemu-sta...@nongnu.org Signed-off-by: Fam Zheng --- util/osdep.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/osdep.c b/util/osdep.c