Re: [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Andre Przywara
Kevin Wolf wrote: >> @@ -302,12 +306,14 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen) #ifdef CONFIG_ACCEPT4 ret = accept4(s, addr, addrlen, SOCK_CLOEXEC); -#else +if (ret != -1 || errno != EINVAL) { Shouldn't this be an ENOSYS? Oh, right you are. This wa

Re: [Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Kevin Wolf
Am 18.12.2009 10:45, schrieb Andre Przywara: > If QEMU finds newer kernel header files on compilation time, it will use > advertised features like pipe2 or SOCK_CLOEXEC by just doing a compile test. > If later the executables are executed on an older kernel (<2.6.27, > like Xen Dom0 2.6.18), then Q

[Qemu-devel] [PATCH] osdep: Fix runtime failure on older Linux kernels

2009-12-18 Thread Andre Przywara
If QEMU finds newer kernel header files on compilation time, it will use advertised features like pipe2 or SOCK_CLOEXEC by just doing a compile test. If later the executables are executed on an older kernel (<2.6.27, like Xen Dom0 2.6.18), then QEMU will fail on opening sockets and creating pipes a