Re: [Qemu-devel] [PATCH] optionrom: fix bugs in signrom.sh

2010-11-21 Thread Anthony Liguori
On 11/16/2010 08:33 AM, Avi Kivity wrote: signrom.sh has multiple bugs: - the last byte is considered when calculating the existing checksum, but not when computing the correction - apprently the 'expr' expression overflows and produces incorrect results with larger roms - if the checksum

[Qemu-devel] [PATCH] optionrom: fix bugs in signrom.sh

2010-11-16 Thread Avi Kivity
signrom.sh has multiple bugs: - the last byte is considered when calculating the existing checksum, but not when computing the correction - apprently the 'expr' expression overflows and produces incorrect results with larger roms - if the checksum happened to be zero, we calculated the correct