Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-24 Thread Stefan Hajnoczi
On Fri, Mar 24, 2017 at 12:29:39AM +, Xu, Anthony wrote: > > Perhaps all trace.o files should be put into their own .a instead of > > being added directly to the linker line: > > > > COMMON_LDADDS = $(trace-obj-y) libqemuutil.a libqemustub.a > > > > I think the linker would only pull in .o fi

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-23 Thread Xu, Anthony
> Perhaps all trace.o files should be put into their own .a instead of > being added directly to the linker line: > > COMMON_LDADDS = $(trace-obj-y) libqemuutil.a libqemustub.a > > I think the linker would only pull in .o files containing symbols that are > actually referenced by the program. Hi

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-23 Thread Stefan Hajnoczi
On Wed, Mar 22, 2017 at 02:37:21PM +0100, Paolo Bonzini wrote: > > > On 22/03/2017 03:03, Xu, Anthony wrote: > > When building target x86_64-softmmu, all other architectures' trace.o are > > linked into > > x86_64-softmmu/qemu-system-x86_64, like hw/arm/trace.o, hw/mips/trace.o > > etc., > >

Re: [Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-22 Thread Paolo Bonzini
On 22/03/2017 03:03, Xu, Anthony wrote: > When building target x86_64-softmmu, all other architectures' trace.o are > linked into > x86_64-softmmu/qemu-system-x86_64, like hw/arm/trace.o, hw/mips/trace.o etc., > that is not necessary. > Same thing happens when building other targets. > > Onl

[Qemu-devel] [PATCH] only link current target arch traces to qemu-system

2017-03-21 Thread Xu, Anthony
When building target x86_64-softmmu, all other architectures' trace.o are linked into x86_64-softmmu/qemu-system-x86_64, like hw/arm/trace.o, hw/mips/trace.o etc., that is not necessary. Same thing happens when building other targets. Only current target arch traces should be linked into qemu-