Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-26 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:19:32AM +1000, Alexey Kardashevskiy wrote: > On 09/24/2014 07:47 PM, Stefan Hajnoczi wrote: > > On Tue, Sep 23, 2014 at 08:19:41PM +1000, Alexey Kardashevskiy wrote: > >> This adds a stub for ohci_td_pkt() function (which traces packets) > >> when configured without --ena

Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-24 Thread Alexey Kardashevskiy
On 09/24/2014 07:47 PM, Stefan Hajnoczi wrote: > On Tue, Sep 23, 2014 at 08:19:41PM +1000, Alexey Kardashevskiy wrote: >> This adds a stub for ohci_td_pkt() function (which traces packets) >> when configured without --enable-trace-backend >> >> Signed-off-by: Alexey Kardashevskiy >> --- >> >> It s

Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-24 Thread Alexey Kardashevskiy
On 09/23/2014 08:52 PM, Gerd Hoffmann wrote: > On Di, 2014-09-23 at 20:19 +1000, Alexey Kardashevskiy wrote: >> This adds a stub for ohci_td_pkt() function (which traces packets) >> when configured without --enable-trace-backend > > Ah, cool. Just noticed that, while doing usb patch queue test bu

Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-24 Thread Stefan Hajnoczi
On Tue, Sep 23, 2014 at 08:19:41PM +1000, Alexey Kardashevskiy wrote: > This adds a stub for ohci_td_pkt() function (which traces packets) > when configured without --enable-trace-backend > > Signed-off-by: Alexey Kardashevskiy > --- > > It should probably be squashed to > [PATCH] ohci: Convert

Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-23 Thread Gerd Hoffmann
On Di, 2014-09-23 at 20:19 +1000, Alexey Kardashevskiy wrote: > This adds a stub for ohci_td_pkt() function (which traces packets) > when configured without --enable-trace-backend Ah, cool. Just noticed that, while doing usb patch queue test builds for the next pull req. > It should probably be

[Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-23 Thread Alexey Kardashevskiy
This adds a stub for ohci_td_pkt() function (which traces packets) when configured without --enable-trace-backend Signed-off-by: Alexey Kardashevskiy --- It should probably be squashed to [PATCH] ohci: Convert fprint/DPRINTF/print to traces Sorry about that... --- hw/usb/hcd-ohci.c | 6 ++