Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-20 Thread Klaus Birkelund
On Mon, May 20, 2019 at 09:05:57AM -0600, Keith Busch wrote: > On Sat, May 18, 2019 at 09:39:05AM +0200, Klaus Birkelund Jensen wrote: > > `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of > > `qemu_iovec_*from*_buf` when the request involved the controller memory > > buffer. > >

Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-20 Thread Keith Busch
On Sat, May 18, 2019 at 09:39:05AM +0200, Klaus Birkelund Jensen wrote: > `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of > `qemu_iovec_*from*_buf` when the request involved the controller memory > buffer. > > Signed-off-by: Klaus Birkelund Jensen I was wondering how this mi

Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-20 Thread Kevin Wolf
Am 18.05.2019 um 09:39 hat Klaus Birkelund Jensen geschrieben: > `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of > `qemu_iovec_*from*_buf` when the request involved the controller memory > buffer. > > Signed-off-by: Klaus Birkelund Jensen Thanks, applied to the block branch.

Re: [Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-18 Thread Heitke, Kenneth
On 5/18/2019 1:39 AM, Klaus Birkelund Jensen wrote: `nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of `qemu_iovec_*from*_buf` when the request involved the controller memory buffer. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 inse

[Qemu-devel] [PATCH] nvme: fix copy direction in DMA reads going to CMB

2019-05-18 Thread Klaus Birkelund Jensen
`nvme_dma_read_prp` erronously used `qemu_iovec_*to*_buf` instead of `qemu_iovec_*from*_buf` when the request involved the controller memory buffer. Signed-off-by: Klaus Birkelund Jensen --- hw/block/nvme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/