Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-25 Thread Eric Blake
On 05/25/2018 01:25 AM, Fam Zheng wrote: And that makes five labels in total, I'm not sure I like it: fail_handler: aio_set_event_notifier(bdrv_get_aio_context(bs), &s->irq_notifier, false, NULL, NULL); fail_queue: nvme_free_queue_pair(bs, s->queues[0]); fa

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-25 Thread Markus Armbruster
Fam Zheng writes: > On Fri, 05/25 07:47, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Thu, 05/24 19:16, Paolo Bonzini wrote: >> >> On 21/05/2018 08:35, Fam Zheng wrote: >> >> > Coverity doesn't like the tests under fail label (report CID 1385847). >> >> > Reset the fields so the cle

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-24 Thread Fam Zheng
On Fri, 05/25 07:47, Markus Armbruster wrote: > Fam Zheng writes: > > > On Thu, 05/24 19:16, Paolo Bonzini wrote: > >> On 21/05/2018 08:35, Fam Zheng wrote: > >> > Coverity doesn't like the tests under fail label (report CID 1385847). > >> > Reset the fields so the clean up order is more apparent

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-24 Thread Markus Armbruster
Fam Zheng writes: > On Thu, 05/24 19:16, Paolo Bonzini wrote: >> On 21/05/2018 08:35, Fam Zheng wrote: >> > Coverity doesn't like the tests under fail label (report CID 1385847). >> > Reset the fields so the clean up order is more apparent. >> > >> > Signed-off-by: Fam Zheng >> > --- >> > bloc

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-24 Thread Fam Zheng
On Thu, 05/24 19:16, Paolo Bonzini wrote: > On 21/05/2018 08:35, Fam Zheng wrote: > > Coverity doesn't like the tests under fail label (report CID 1385847). > > Reset the fields so the clean up order is more apparent. > > > > Signed-off-by: Fam Zheng > > --- > > block/nvme.c | 7 +++ > > 1 f

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-24 Thread Paolo Bonzini
On 21/05/2018 08:35, Fam Zheng wrote: > Coverity doesn't like the tests under fail label (report CID 1385847). > Reset the fields so the clean up order is more apparent. > > Signed-off-by: Fam Zheng > --- > block/nvme.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/block/nvme.

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-21 Thread Fam Zheng
On Mon, 05/21 09:35, Peter Maydell wrote: > On 21 May 2018 at 07:35, Fam Zheng wrote: > > Coverity doesn't like the tests under fail label (report CID 1385847). > > Reset the fields so the clean up order is more apparent. > > > > Signed-off-by: Fam Zheng > > --- > > block/nvme.c | 7 +++ > >

Re: [Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-21 Thread Peter Maydell
On 21 May 2018 at 07:35, Fam Zheng wrote: > Coverity doesn't like the tests under fail label (report CID 1385847). > Reset the fields so the clean up order is more apparent. > > Signed-off-by: Fam Zheng > --- > block/nvme.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/block/nv

[Qemu-devel] [PATCH] nvme: Make nvme_init error handling code more readable

2018-05-20 Thread Fam Zheng
Coverity doesn't like the tests under fail label (report CID 1385847). Reset the fields so the clean up order is more apparent. Signed-off-by: Fam Zheng --- block/nvme.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/block/nvme.c b/block/nvme.c index 6f71122bf5..8239b920c8 100644 ---