Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-08-22 Thread Stefan Hajnoczi
On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so fo

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-08-21 Thread Christoph Hellwig
This didn't seem to make it into mainline, does it need a ping?

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-06-19 Thread Keith Busch
On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so fo

[Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-05-28 Thread Dan Aloni
The number of queues that should be return by the admin command should: 1) Only mention the number of non-admin queues. 2) It is zero-based, meaning that '0 == one non-admin queue', '1 == two non-admin queues', and so forth. Because our `num_queues` means the number of queues _plus_ the