Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-08-22 Thread Stefan Hajnoczi
On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so fo

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-08-21 Thread Christoph Hellwig
This didn't seem to make it into mainline, does it need a ping?

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-06-19 Thread Keith Busch
On Sun, May 28, 2017 at 04:06:49PM +0300, Dan Aloni wrote: > The number of queues that should be return by the admin command should: > > 1) Only mention the number of non-admin queues. > 2) It is zero-based, meaning that '0 == one non-admin queue', > '1 == two non-admin queues', and so fo

[Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature, again

2017-05-28 Thread Dan Aloni
The number of queues that should be return by the admin command should: 1) Only mention the number of non-admin queues. 2) It is zero-based, meaning that '0 == one non-admin queue', '1 == two non-admin queues', and so forth. Because our `num_queues` means the number of queues _plus_ the

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2015-01-08 Thread Keith Busch
On Wed, 7 Jan 2015, Stefan Hajnoczi wrote: On Fri, Dec 05, 2014 at 02:40:24PM +0200, a...@e8storage.com wrote: From: Alex Friedman According to the specification, the low 16 bits should contain the number of I/O submission queues, and the high 16 bits should contain the number of I/O completio

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2015-01-07 Thread Stefan Hajnoczi
On Fri, Dec 05, 2014 at 02:40:24PM +0200, a...@e8storage.com wrote: > From: Alex Friedman > > According to the specification, the low 16 bits should contain the number of > I/O submission queues, and the high 16 bits should contain the number of > I/O completion queues. > > Signed-off-by: Alex F

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2014-12-29 Thread Alex Friedman
*ping* https://patchwork.ozlabs.org/patch/418107/ Alex Friedman E8 Storage VP R&D a...@e8storage.com Mobile: +972-54-579-7646 On Fri, Dec 5, 2014 at 5:45 PM, Keith Busch wrote: > On Fri, 5 Dec 2014, a...@e8storage.com wrote: > >> From: Alex Friedman >> >> According to the specification, the l

Re: [Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2014-12-05 Thread Keith Busch
On Fri, 5 Dec 2014, a...@e8storage.com wrote: From: Alex Friedman According to the specification, the low 16 bits should contain the number of I/O submission queues, and the high 16 bits should contain the number of I/O completion queues. Signed-off-by: Alex Friedman Good catch, thanks for

[Qemu-devel] [PATCH] nvme: Fix get/set number of queues feature

2014-12-05 Thread alex
From: Alex Friedman According to the specification, the low 16 bits should contain the number of I/O submission queues, and the high 16 bits should contain the number of I/O completion queues. Signed-off-by: Alex Friedman --- hw/block/nvme.c | 6 -- 1 file changed, 4 insertions(+), 2 delet