Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-13 Thread Dmitry Fleytman
> On 12 Aug 2016, at 14:11 PM, 李强 wrote: > > Hi Dmitry > >> >>> On 12 Aug 2016, at 04:21 AM, 李强 wrote: >>> >>> Hello Dmitry, >>> >>> I don't see the assert for 'max_frags' in vmxnet device emulation. Could you >> please point it out? >> >> >> Hi, >> >> I mean that max_frags for vmxnet3 d

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread Dmitry Fleytman
> On 12 Aug 2016, at 04:21 AM, 李强 wrote: > > Hello Dmitry, > > I don't see the assert for 'max_frags' in vmxnet device emulation. Could you > please point it out? Hi, I mean that max_frags for vmxnet3 device is a size of TX ring so assert introduced by this patch will fire all the time.

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-11 Thread Dmitry Fleytman
> On 11 Aug 2016, at 11:08 AM, Dmitry Fleytman wrote: > > > Acked-by: Dmitry Fleytman Oops, please ignore this ACK, I replied to the wrong e-mail. As far as I see max_frags for VMXNET3 is a size of device’s TX ring so this will always assert. I don’t think we need this limitation in the de

Re: [Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-11 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 10 Aug 2016, at 23:38 PM, P J P wrote: > > From: Li Qiang > > When net transport abstraction layer initialises the pkt, > the maximum fragmentation count is not checked. This could > lead to an integer overflow causing a NULL pointer dereference. > Add check to

[Qemu-devel] [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-10 Thread P J P
From: Li Qiang When net transport abstraction layer initialises the pkt, the maximum fragmentation count is not checked. This could lead to an integer overflow causing a NULL pointer dereference. Add check to avoid it. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/net/net_tx_pkt