Re: [Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-18 Thread Zhi Yong Wu
Good catch, thanks, please next version. On Mon, Jun 18, 2012 at 6:22 PM, Stefan Hajnoczi wrote: > On Sun, Jun 17, 2012 at 12:30:32AM +0800, zwu.ker...@gmail.com wrote: >> +static int print_vlan(DeviceState *dev, Property *prop, char *dest, size_t >> len) >> +{ >> +    NetClientState **ptr = qde

Re: [Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-18 Thread Stefan Hajnoczi
On Sun, Jun 17, 2012 at 12:30:32AM +0800, zwu.ker...@gmail.com wrote: > +static int print_vlan(DeviceState *dev, Property *prop, char *dest, size_t > len) > +{ > +NetClientState **ptr = qdev_get_prop_ptr(dev, prop); > + > +if (*ptr) { > +unsigned int id; > +if (!net_hub_id_

[Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-16 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function