Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-06 Thread Stefan Hajnoczi
On Tue, Dec 23, 2014 at 05:53:19PM +0100, Paolo Bonzini wrote: > All NICs have a cleanup function that, in most cases, zeroes the pointer > to the NICState. In some cases, it frees data belonging to the NIC. > > However, this function is never called except when exiting from QEMU. > It is not nec

Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-06 Thread Stefan Hajnoczi
On Fri, Jan 02, 2015 at 05:22:27PM +0100, Paolo Bonzini wrote: > > > On 02/01/2015 15:00, Stefan Hajnoczi wrote: > >>> This cleanup function gets in the way of making the > >>> NetClientStates for the NIC hold an object_ref reference to > >>> the object, so get rid of it. > > This patch does not

Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-02 Thread Paolo Bonzini
On 02/01/2015 15:00, Stefan Hajnoczi wrote: >>> This cleanup function gets in the way of making the >>> NetClientStates for the NIC hold an object_ref reference to >>> the object, so get rid of it. > This patch does not drop NetClientInfo->cleanup() and clean up > net.c. Do you have plans for a

Re: [Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2015-01-02 Thread Stefan Hajnoczi
On Tue, Dec 23, 2014 at 05:53:19PM +0100, Paolo Bonzini wrote: > All NICs have a cleanup function that, in most cases, zeroes the pointer > to the NICState. In some cases, it frees data belonging to the NIC. > > However, this function is never called except when exiting from QEMU. > It is not nec

[Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2014-12-23 Thread Paolo Bonzini
All NICs have a cleanup function that, in most cases, zeroes the pointer to the NICState. In some cases, it frees data belonging to the NIC. However, this function is never called except when exiting from QEMU. It is not necessary to NULL pointers and free data here; the right place to do that wo