Re: [Qemu-devel] [PATCH] net: fix default MAC assignment for hotplugged NICs

2011-07-28 Thread Marcelo Tosatti
On Thu, Jul 28, 2011 at 04:22:09PM +0100, Peter Maydell wrote: > On 28 July 2011 16:12, Marcelo Tosatti wrote: > > > > The index for assignment of default MAC address is duplicated: > > qemu_macaddr_default_if_unset has its own variable and net_init_nic uses > > the nic table index. > > Isn't thi

Re: [Qemu-devel] [PATCH] net: fix default MAC assignment for hotplugged NICs

2011-07-28 Thread Peter Maydell
On 28 July 2011 16:12, Marcelo Tosatti wrote: > > The index for assignment of default MAC address is duplicated: > qemu_macaddr_default_if_unset has its own variable and net_init_nic uses > the nic table index. Isn't this already fixed by commit 6eed18568d ? -- PMM

[Qemu-devel] [PATCH] net: fix default MAC assignment for hotplugged NICs

2011-07-28 Thread Marcelo Tosatti
The index for assignment of default MAC address is duplicated: qemu_macaddr_default_if_unset has its own variable and net_init_nic uses the nic table index. This leads to assignment of same MAC addresses to NICs initialized via command line and hotplugged ones. Fix by not assigning default MAC a