Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-08 Thread Jason Wang
On 09/05/2014 12:40 AM, Peter Maydell wrote: > On 4 September 2014 17:21, Stefan Hajnoczi wrote: >> Unfortunately this patch breaks aarch64-softmmu qtests: >> GTESTER check-qtest-aarch64 >> Broken pipe >> GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73 >> >> Please take a look at w

Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-08 Thread Jason Wang
On 09/05/2014 12:21 AM, Stefan Hajnoczi wrote: > Unfortunately this patch breaks aarch64-softmmu qtests: > GTESTER check-qtest-aarch64 > Broken pipe > GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73 > > Please take a look at what is causing this. > > Dropped from the net branch. > >

Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-04 Thread Peter Maydell
On 4 September 2014 17:21, Stefan Hajnoczi wrote: > Unfortunately this patch breaks aarch64-softmmu qtests: > GTESTER check-qtest-aarch64 > Broken pipe > GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73 > > Please take a look at what is causing this. Specifically, it breaks on all

Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-04 Thread Stefan Hajnoczi
Unfortunately this patch breaks aarch64-softmmu qtests: GTESTER check-qtest-aarch64 Broken pipe GTester: last random seed: R02S6d8ab263ca56f8ae7a4b47bdf93fbc73 Please take a look at what is causing this. Dropped from the net branch. Stefan

Re: [Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-09-02 Thread Stefan Hajnoczi
On Thu, Aug 28, 2014 at 03:41:25PM +0800, Jason Wang wrote: > Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue > support) tries to use set_pointer() and get_pointer() to set and get > NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This > trick works but result a uncl

[Qemu-devel] [PATCH] net: don't use set/get_pointer() in set/get_netdev()

2014-08-28 Thread Jason Wang
Commit 1ceef9f27359cbe92ef124bf74de6f792e71f6fb (net: multiqueue support) tries to use set_pointer() and get_pointer() to set and get NICPeers which is not a pointer defined in DEFINE_PROP_NETDEV. This trick works but result a unclean and fragile implementation (e.g print_netdev and parse_netdev).