Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-28 Thread Pankaj Gupta
> > > > Ping. > > > > Can I get any suggestions on this patch. > > > > Best regards, > > Pankaj > > > > > > > > > vhostforce was added to enable vhost when > > > guest don't have MSI-X support. > > > Now, we have scenarios like DPDK in Guest which dont use > > > interrupts and still use

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/28/2015 02:28 PM, Michal Privoznik wrote: > On 28.05.2015 05:36, Jason Wang wrote: >> >> On 05/28/2015 11:21 AM, Jason Wang wrote: >>> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: >> On 05/27/2015 02:26 PM, Pankaj Gup

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Michal Privoznik
On 28.05.2015 05:36, Jason Wang wrote: > > > On 05/28/2015 11:21 AM, Jason Wang wrote: >> >> On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >>> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: > > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>> Ping. >>> >>> Can

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/28/2015 11:21 AM, Jason Wang wrote: > > On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: >> On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >> Ping. >> >> Can I get any suggestions on this patch. >> >> Be

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/27/2015 07:57 PM, Michael S. Tsirkin wrote: > On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: >> > >> > >> > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: >>> > > Ping. >>> > > >>> > > Can I get any suggestions on this patch. >>> > > >>> > > Best regards, >>> > > Pankaj >>> > >

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Michael S. Tsirkin
On Wed, May 27, 2015 at 02:26:43AM -0400, Pankaj Gupta wrote: > > Ping. > > Can I get any suggestions on this patch. > > Best regards, > Pankaj > > > > vhostforce was added to enable vhost when > > guest don't have MSI-X support. > > Now, we have scenarios like DPDK in Guest which dont use

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Michael S. Tsirkin
On Wed, May 27, 2015 at 04:45:34PM +0800, Jason Wang wrote: > > > On 05/27/2015 02:26 PM, Pankaj Gupta wrote: > > Ping. > > > > Can I get any suggestions on this patch. > > > > Best regards, > > Pankaj > > > >> vhostforce was added to enable vhost when > >> guest don't have MSI-X support. > >>

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-27 Thread Jason Wang
On 05/27/2015 02:26 PM, Pankaj Gupta wrote: > Ping. > > Can I get any suggestions on this patch. > > Best regards, > Pankaj > >> vhostforce was added to enable vhost when >> guest don't have MSI-X support. >> Now, we have scenarios like DPDK in Guest which dont use >> interrupts and still use

Re: [Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-05-26 Thread Pankaj Gupta
Ping. Can I get any suggestions on this patch. Best regards, Pankaj > > vhostforce was added to enable vhost when > guest don't have MSI-X support. > Now, we have scenarios like DPDK in Guest which dont use > interrupts and still use vhost. Also, performance of guests > without MSI-X suppo

[Qemu-devel] [PATCH] net: Remove vhostforce option in addition to vhost parameter

2015-03-08 Thread Pankaj Gupta
vhostforce was added to enable vhost when guest don't have MSI-X support. Now, we have scenarios like DPDK in Guest which dont use interrupts and still use vhost. Also, performance of guests without MSI-X support is getting less popular. Its OK to remove this extra option and enable vhost