Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-16 Thread Paolo Bonzini
On 16/12/2015 08:20, Thomas Huth wrote: > Ah, ok, that makes more sense... anyway, "-device ?" also lists some > devices like "ne2k_isa", ""usb-bt-dongle" and "vmxnet3" ... I somewhat > doubt that we want to have these in the list of "-net nic" supported > devices, too. Why not? > ... hmmm, by

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 19:08, Paolo Bonzini wrote: > > > On 15/12/2015 18:50, Thomas Huth wrote: >> On 15/12/15 18:31, Paolo Bonzini wrote: >>> >>> On 15/12/2015 18:15, Thomas Huth wrote: On 15/12/15 17:21, Paolo Bonzini wrote: >> [...] > For example you could print all DEVICE_CATEGORY_NETWORK devi

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 18:15, Thomas Huth wrote: > On 15/12/15 17:21, Paolo Bonzini wrote: >> On 15/12/2015 17:01, Thomas Huth wrote: >>> Some options work with "-net", some only work with "-netdev", >>> and the ones that work with both often also behave slightly differently (see >>> [1] for example). >>

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 17:17, Peter Maydell wrote: > On 15 December 2015 at 12:51, Paolo Bonzini wrote: >> Honestly, I still do not believe that they will be removed. They are >> little more than syntactic sugar at this point. > > If they're just syntactic sugar, what is the new-style command > line mechan

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 18:31, Paolo Bonzini wrote: > > On 15/12/2015 18:15, Thomas Huth wrote: >> On 15/12/15 17:21, Paolo Bonzini wrote: [...] >>> For example you could print all DEVICE_CATEGORY_NETWORK devices that >>> support device_add. >> >> I think that would not work since spapr-vlan is not hot-plugga

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 13:51, Paolo Bonzini wrote: > > On 15/12/2015 12:46, Thomas Huth wrote: >> We likely don't want to maintain the legacy -net options forever, >> so let's start informing the users that this option will be >> removed in a future version. However, there are two cases where >> we should no

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Eric Blake
On 12/15/2015 09:21 AM, Paolo Bonzini wrote: > > In fact there isn't much shared code in the is_netdev=0 and is_netdev=1 > cases. Perhaps you could just make a shared function with just > > if (net_client_init_fun[opts->type](opts, name, peer, errp) < 0) { > /* FIXME drop when all i

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
On 15/12/15 17:21, Paolo Bonzini wrote: > > > On 15/12/2015 17:01, Thomas Huth wrote: >> Some options work with "-net", some only work with "-netdev", >> and the ones that work with both often also behave slightly differently (see >> [1] for example). > > This example is about -net nic, which yo

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 12:51, Paolo Bonzini wrote: > Honestly, I still do not believe that they will be removed. They are > little more than syntactic sugar at this point. If they're just syntactic sugar, what is the new-style command line mechanism for configuring boards with embedded network c

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 18:50, Thomas Huth wrote: > On 15/12/15 18:31, Paolo Bonzini wrote: >> >> On 15/12/2015 18:15, Thomas Huth wrote: >>> On 15/12/15 17:21, Paolo Bonzini wrote: > [...] For example you could print all DEVICE_CATEGORY_NETWORK devices that support device_add. >>> >>> I think th

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Peter Maydell
On 15 December 2015 at 16:33, Thomas Huth wrote: > On 15/12/15 17:17, Peter Maydell wrote: >> If they're just syntactic sugar, what is the new-style command >> line mechanism for configuring boards with embedded network >> controller devices? Last time I looked at this that was just >> impossible.

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 17:01, Thomas Huth wrote: > Some options work with "-net", some only work with "-netdev", > and the ones that work with both often also behave slightly differently (see > [1] for example). This example is about -net nic, which you're keeping. What are the options that differ betwe

Re: [Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 12:46, Thomas Huth wrote: > We likely don't want to maintain the legacy -net options forever, > so let's start informing the users that this option will be > removed in a future version. However, there are two cases where > we should not spill out a message yet: First is the "-net n

[Qemu-devel] [PATCH] net: Inform the user about deprecated -net options

2015-12-15 Thread Thomas Huth
We likely don't want to maintain the legacy -net options forever, so let's start informing the users that this option will be removed in a future version. However, there are two cases where we should not spill out a message yet: First is the "-net nic" option which might still be required to config