Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Alex Bennée
Benjamin Herrenschmidt writes: > On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >> >> > > >> > > total: 428 errors, 73 warnings, 1950 lines checked >> > > >> > > Your patch has style problems, please review.If any of these >> > > errors >> > > are false positives report them to the mainta

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Benjamin Herrenschmidt
On Wed, 2016-09-21 at 11:16 +0100, Alex Bennée wrote: >  > > > > > > total: 428 errors, 73 warnings, 1950 lines checked > > > > > > Your patch has style problems, please review.If any of these > > > errors > > > are false positives report them to the maintainer, see > > > CHECKPATCH in MAINTAINER

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-09-21 Thread Alex Bennée
Benjamin Herrenschmidt writes: > On Sun, 2016-08-14 at 15:54 -0700, no-reply@ec2-52-6-146-230.compute- > 1.amazonaws.com wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output >> below for more information: > > Bla bla bla bla ... > > Seriously, we have nazi stylebo

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
On Mon, 2016-08-15 at 09:59 +1000, Benjamin Herrenschmidt wrote: > Bla bla bla bla ... > > Seriously, we have nazi stylebot on the list now ? > > I made conscious decisions to style it this way and as far as the tabs > in the .h are concerned, that's because the file is lifted from Linux > and I'

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
de conscious decisions to style it this way and as far as the tabs in the .h are concerned, that's because the file is lifted from Linux and I'd like to keep it intact as much as possible. > Message-id: 1471214931.12231.71.ca...@kernel.crashing.org > Subject: [Qemu-devel] [PATCH] net: Ad

Re: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1471214931.12231.71.ca...@kernel.crashing.org Subject: [Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth Type: series === TEST SCRIPT BEGIN === #!/bin

[Qemu-devel] [PATCH] net: Add SunGEM device emulation as found on Apple UniNorth

2016-08-14 Thread Benjamin Herrenschmidt
This adds a simplistic emulation of the Sun GEM ethernet controller found in Apple ASICs. Currently we only support the Apple UniNorth 1.x variant, but the other Apple or Sun variants should mostly be a matter of adding PCI IDs options. It doesn't (yet) support state saving, but neither does the