Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Jason Wang
On 2017年11月13日 17:51, Peter Maydell wrote: On 13 November 2017 at 07:13, Jason Wang wrote: On 2017年11月06日 21:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 07:13, Jason Wang wrote: > > > On 2017年11月06日 21:28, Jens Freimann wrote: >> >> This fixes coverity issue CID1005339. >> >> Make sure that saddr is not used uninitialized if the >> mcast parameter is NULL. >> >> Cc: qemu-sta...@nongnu.org >> Reported-by: Peter Maydell >> Si

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-12 Thread Jason Wang
On 2017年11月06日 21:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann --- net/socket.c | 4 ++-- 1 file changed, 2

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 13:48, Jens Freimann wrote: > On Mon, Nov 06, 2017 at 01:29:42PM +, Peter Maydell wrote: >> Do we really need the initialization here? With the two if() >> conditions aligned we should be properly initializing it >> in all the cases we use it, or have I missed one? > > >

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
On Mon, Nov 06, 2017 at 01:33:49PM +, Darren Kenny wrote: Hi Jan, On Mon, Nov 06, 2017 at 02:28:05PM +0100, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Pet

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
On Mon, Nov 06, 2017 at 01:29:42PM +, Peter Maydell wrote: On 6 November 2017 at 13:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-o

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Darren Kenny
Hi Jan, On Mon, Nov 06, 2017 at 02:28:05PM +0100, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann --- net/socket.c | 4

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Peter Maydell
On 6 November 2017 at 13:28, Jens Freimann wrote: > This fixes coverity issue CID1005339. > > Make sure that saddr is not used uninitialized if the > mcast parameter is NULL. > > Cc: qemu-sta...@nongnu.org > Reported-by: Peter Maydell > Signed-off-by: Jens Freimann > --- > net/socket.c | 4 ++--

[Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-06 Thread Jens Freimann
This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by: Peter Maydell Signed-off-by: Jens Freimann --- net/socket.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/s