Re: [Qemu-devel] [PATCH] net/rocker: Cleanup the useless return value check

2017-05-23 Thread Mao Zhongyi
On 05/24/2017 11:31 AM, Jason Wang wrote: On 2017年05月24日 10:57, Mao Zhongyi wrote: None of pci_dma_read()'s callers check the return value except rocker. There is no need to check it because it always return 0. So the check work is useless. Remove it entirely. Suggested-by: Markus Armbruste

Re: [Qemu-devel] [PATCH] net/rocker: Cleanup the useless return value check

2017-05-23 Thread Jason Wang
On 2017年05月24日 10:57, Mao Zhongyi wrote: None of pci_dma_read()'s callers check the return value except rocker. There is no need to check it because it always return 0. So the check work is useless. Remove it entirely. Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/net/r

[Qemu-devel] [PATCH] net/rocker: Cleanup the useless return value check

2017-05-23 Thread Mao Zhongyi
None of pci_dma_read()'s callers check the return value except rocker. There is no need to check it because it always return 0. So the check work is useless. Remove it entirely. Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi --- hw/net/rocker/rocker.c | 9 +++-- hw/net/rock