Re: [Qemu-devel] [PATCH] net/net: Bugfix for net_fill_rstate()

2016-08-17 Thread Zhang Chen
On 08/18/2016 09:31 AM, Li Zhijian wrote: /* * Returns * 0: SocketReadState is not ready * 1: SocketReadState is ready * otherwise error occurs */ int net_fill_rstate(SocketReadState *rs, const uint8_t *buf, int size) it seems you need to fix the returns and comments too. simply, just re

Re: [Qemu-devel] [PATCH] net/net: Bugfix for net_fill_rstate()

2016-08-17 Thread Li Zhijian
/* * Returns * 0: SocketReadState is not ready * 1: SocketReadState is ready * otherwise error occurs */ int net_fill_rstate(SocketReadState *rs, const uint8_t *buf, int size) it seems you need to fix the returns and comments too. simply, just remove the 'return 1;' would be OK ? because th

[Qemu-devel] [PATCH] net/net: Bugfix for net_fill_rstate()

2016-08-17 Thread Zhang Chen
When network is busy, we will receive multiple packets at one time. this bug will lost packets that comes late. Signed-off-by: Zhang Chen Signed-off-by: Li Zhijian --- net/net.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/net.c b/net/net.c index a8e2e6b..8f3237e 1