Patchew URL:
https://patchew.org/QEMU/20190128165830.165170-1-vsement...@virtuozzo.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEG
On 2/1/19 12:27 PM, Eric Blake wrote:
>
>
>> +
>> +#define DEF_NBD_READ(bits) \
>> +static inline int nbd_read ## bits(QIOChannel *ioc, uint ## bits ## _t *
>> val, \
>
> checkpatch didn't flag it, but I think our style is '*val', not '* val'.
But it DOES flag '*val' as a false positive. Oh
On 1/28/19 10:58 AM, Vladimir Sementsov-Ogievskiy wrote:
> We generally do very similar things around nbd_read: error_prepend,
> specifying, what we have tried to read and be_to_cpu conversion of
> integers.
>
> So, it seems reasonable to move common things to helper functions,
> which:
> 1. simpl
We generally do very similar things around nbd_read: error_prepend,
specifying, what we have tried to read and be_to_cpu conversion of
integers.
So, it seems reasonable to move common things to helper functions,
which:
1. simplify code a bit
2. generalize nbd_read error descriptions, all starting
