Re: [Qemu-devel] [PATCH] nbd: avoid unaligned uint64_t store

2016-02-04 Thread Paolo Bonzini
On 04/02/2016 16:45, John Snow wrote: > > > On 02/04/2016 05:27 AM, Paolo Bonzini wrote: >> >> >> On 04/02/2016 00:48, John Snow wrote: >>> cpu_to_be64w can't be used to make unaligned stores, but stq_be_p can. >>> The other stores in this routine are left alone, they're aligned already. >>> >>

Re: [Qemu-devel] [PATCH] nbd: avoid unaligned uint64_t store

2016-02-04 Thread John Snow
On 02/04/2016 05:27 AM, Paolo Bonzini wrote: > > > On 04/02/2016 00:48, John Snow wrote: >> cpu_to_be64w can't be used to make unaligned stores, but stq_be_p can. >> The other stores in this routine are left alone, they're aligned already. >> >> Signed-off-by: John Snow >> --- >> nbd/server.c

Re: [Qemu-devel] [PATCH] nbd: avoid unaligned uint64_t store

2016-02-04 Thread Paolo Bonzini
On 04/02/2016 00:48, John Snow wrote: > cpu_to_be64w can't be used to make unaligned stores, but stq_be_p can. > The other stores in this routine are left alone, they're aligned already. > > Signed-off-by: John Snow > --- > nbd/server.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[Qemu-devel] [PATCH] nbd: avoid unaligned uint64_t store

2016-02-03 Thread John Snow
cpu_to_be64w can't be used to make unaligned stores, but stq_be_p can. The other stores in this routine are left alone, they're aligned already. Signed-off-by: John Snow --- nbd/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c index 1ec79cf