Re: [Qemu-devel] [PATCH] nbd: Don't inf-loop on early EOF

2016-11-09 Thread Paolo Bonzini
On 07/11/2016 23:45, Eric Blake wrote: > On 11/07/2016 04:22 PM, Max Reitz wrote: >> On 07.11.2016 21:38, Eric Blake wrote: >>> Commit 7d3123e converted a single read_sync() into a while loop >>> that assumed that read_sync() would either make progress or give >>> an error. But when the server ha

Re: [Qemu-devel] [PATCH] nbd: Don't inf-loop on early EOF

2016-11-07 Thread Eric Blake
On 11/07/2016 04:22 PM, Max Reitz wrote: > On 07.11.2016 21:38, Eric Blake wrote: >> Commit 7d3123e converted a single read_sync() into a while loop >> that assumed that read_sync() would either make progress or give >> an error. But when the server hangs up early, the client sees >> EOF (a read_sy

Re: [Qemu-devel] [PATCH] nbd: Don't inf-loop on early EOF

2016-11-07 Thread Max Reitz
On 07.11.2016 21:38, Eric Blake wrote: > Commit 7d3123e converted a single read_sync() into a while loop > that assumed that read_sync() would either make progress or give > an error. But when the server hangs up early, the client sees > EOF (a read_sync() of 0) and never makes progress, which in t

[Qemu-devel] [PATCH] nbd: Don't inf-loop on early EOF

2016-11-07 Thread Eric Blake
Commit 7d3123e converted a single read_sync() into a while loop that assumed that read_sync() would either make progress or give an error. But when the server hangs up early, the client sees EOF (a read_sync() of 0) and never makes progress, which in turn caused qemu-iotest './check -nbd 83' to go