Re: [Qemu-devel] [PATCH] nand: Don't use qdev_create() in nand_init()

2014-02-08 Thread Andreas Färber
Am 05.02.2014 15:56, schrieb Igor Mammedov: > On Wed, 5 Feb 2014 15:30:53 +0100 > Andreas Färber wrote: > >> Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit >> from Sysbus) changed the parent type of TYPE_NAND but continued to use >> qdev_create(), which handled a NULL BusSt

Re: [Qemu-devel] [PATCH] nand: Don't use qdev_create() in nand_init()

2014-02-05 Thread Igor Mammedov
On Wed, 5 Feb 2014 15:30:53 +0100 Andreas Färber wrote: > Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit > from Sysbus) changed the parent type of TYPE_NAND but continued to use > qdev_create(), which handled a NULL BusState as SysBus. > > Use object_new() instead, and reu

[Qemu-devel] [PATCH] nand: Don't use qdev_create() in nand_init()

2014-02-05 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) changed the parent type of TYPE_NAND but continued to use qdev_create(), which handled a NULL BusState as SysBus. Use object_new() instead, and reuse the TYPE_NAND define while at it. Reported-by: Markus Armbruster