Sorry about replying to myself, I only had one coffee today.
There is no need for mb_add_modstring(), we can simply do
get_opt_value(tmpbuf,..) then mb_add_cmdline(&mbs, tmpbuf)
Regards,
Vlad
On 12/15/2016 11:45 AM, Vlad Lungu wrote:
> get_opt_value() truncates the value at the first comma
> Re
get_opt_value() truncates the value at the first comma
Rename mb_add_cmdline() to mb_add_modstring()
Unescape filename too
Add new mb_add_cmdline() using memcpy()
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 23 +--
1 file changed, 17 insertions(+), 6 deletions(-)
di
On 12/15/2016 12:32 AM, Paolo Bonzini wrote:
In other words: this fixes the mb_add_cmdline(kcmdline) case, and
doesn't break comma escaping on the initrd case (because it was
already broken). I don't see a problem with this patch.
>>> ... there is one case of comma escaping that wa
> > > In other words: this fixes the mb_add_cmdline(kcmdline) case, and
> > > doesn't break comma escaping on the initrd case (because it was
> > > already broken). I don't see a problem with this patch.
> >
> > ... there is one case of comma escaping that wasn't broken:
> >
> > $ qemu-system
On Wed, Dec 14, 2016 at 04:38:07PM -0500, Paolo Bonzini wrote:
>
>
> - Original Message -
> > From: "Eduardo Habkost"
> > To: "Paolo Bonzini"
> > Cc: "Vlad Lungu" , qemu-devel@nongnu.org,
> > r...@twiddle.net
> > Sent: Wednesday, December 14, 2016 6:51:44 PM
> > Subject: Re: [PATCH] mu
- Original Message -
> From: "Eduardo Habkost"
> To: "Paolo Bonzini"
> Cc: "Vlad Lungu" , qemu-devel@nongnu.org,
> r...@twiddle.net
> Sent: Wednesday, December 14, 2016 6:51:44 PM
> Subject: Re: [PATCH] multiboot: copy the cmdline verbatim
>
> On Wed, Dec 14, 2016 at 06:20:46PM +0100,
get_opt_value() truncates the value at the first comma
Use memcpy() instead
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 387caa6..b4495ad 100644
--- a/hw/i386/multiboot.c
++
get_opt_value() truncates the value at the first comma.
Use memcpy() instead.
Signed-off-by: Vlad Lungu
---
hw/i386/multiboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 387caa6..b4495ad 100644
--- a/hw/i386/multiboot.c
++
On Wed, Dec 14, 2016 at 06:20:46PM +0100, Paolo Bonzini wrote:
> On 14/12/2016 18:00, Eduardo Habkost wrote:
> > On Wed, Dec 14, 2016 at 05:55:07PM +0100, Paolo Bonzini wrote:
> >>
> >>
> >> On 14/12/2016 17:19, Vlad Lungu wrote:
> >>> get_opt_value() truncates the value at the first comma.
> >>> U
On 14/12/2016 18:00, Eduardo Habkost wrote:
> On Wed, Dec 14, 2016 at 05:55:07PM +0100, Paolo Bonzini wrote:
>>
>>
>> On 14/12/2016 17:19, Vlad Lungu wrote:
>>> get_opt_value() truncates the value at the first comma.
>>> Use memcpy() instead.
>>
>> Looks good since get_opt_value is already used b
On Wed, Dec 14, 2016 at 05:55:07PM +0100, Paolo Bonzini wrote:
>
>
> On 14/12/2016 17:19, Vlad Lungu wrote:
> > get_opt_value() truncates the value at the first comma.
> > Use memcpy() instead.
>
> Looks good since get_opt_value is already used by the caller. Have you
> tested this with multipl
On 14/12/2016 17:19, Vlad Lungu wrote:
> get_opt_value() truncates the value at the first comma.
> Use memcpy() instead.
Looks good since get_opt_value is already used by the caller. Have you
tested this with multiple initrd modules too?
Paolo
> Signed-off-by: Vlad Lungu
> ---
> hw/i386/mul
On Wed, Dec 14, 2016 at 03:35:29PM +0200, Vlad Lungu wrote:
>
> get_opt_value() truncates the value at the first comma
> Use memcpy() instead
>
> Signed-off-by: Vlad Lungu
Your patch is corrupted. I suggest using git-send-email instead
of Thunderbird, but you might want to take a look at:
http:
13 matches
Mail list logo
