Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-12-07 Thread Ladi Prosek
On Thu, Dec 7, 2017 at 7:27 PM, Michael S. Tsirkin wrote: > On Wed, Nov 22, 2017 at 03:22:50PM +0200, Marcel Apfelbaum wrote: >> On 22/11/2017 14:32, Ladi Prosek wrote: >> > On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum >> > wrote: >> > > Hi Ladi, >> > > >> > > On 20/11/2017 16:22, Ladi Pro

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-12-07 Thread Michael S. Tsirkin
On Wed, Nov 22, 2017 at 03:22:50PM +0200, Marcel Apfelbaum wrote: > On 22/11/2017 14:32, Ladi Prosek wrote: > > On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum > > wrote: > > > Hi Ladi, > > > > > > On 20/11/2017 16:22, Ladi Prosek wrote: > > > > > > > > msix_mask_all() is supposed to invoke

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-12-07 Thread Alex Williamson
On Wed, 22 Nov 2017 12:46:45 +0200 Marcel Apfelbaum wrote: > Hi Ladi, > > On 20/11/2017 16:22, Ladi Prosek wrote: > > msix_mask_all() is supposed to invoke the release vector notifier if the > > state of the > > respective vector changed from unmasked or masked. > > You mean from unmasked "

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Marcel Apfelbaum
On 22/11/2017 14:32, Ladi Prosek wrote: On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. You m

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Ladi Prosek
On Wed, Nov 22, 2017 at 11:46 AM, Marcel Apfelbaum wrote: > Hi Ladi, > > On 20/11/2017 16:22, Ladi Prosek wrote: >> >> msix_mask_all() is supposed to invoke the release vector notifier if the >> state of the >> respective vector changed from unmasked or masked. > > > You mean from unmasked "to" ma

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-22 Thread Marcel Apfelbaum
Hi Ladi, On 20/11/2017 16:22, Ladi Prosek wrote: msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. You mean from unmasked "to" masked right? The way it's currently called from msix_reset(), though, may r

Re: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-21 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset Type: series Message-id: 20171120142216.

[Qemu-devel] [PATCH] msix: don't mask already masked vectors on reset

2017-11-20 Thread Ladi Prosek
msix_mask_all() is supposed to invoke the release vector notifier if the state of the respective vector changed from unmasked or masked. The way it's currently called from msix_reset(), though, may result in calling the release notifier even if the vector is already masked. 1) msix_reset() clea