Re: [Qemu-devel] [PATCH] monitor: suggest running "help" for command errors

2015-05-15 Thread Markus Armbruster
Bandan Das writes: > Markus Armbruster writes: > >> Bandan Das writes: >> > ... >>> -static void user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd, >>> +static int user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd, >>> const QDict *params) >>>

Re: [Qemu-devel] [PATCH] monitor: suggest running "help" for command errors

2015-05-14 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > ... >> -static void user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd, >> +static int user_async_cmd_handler(Monitor *mon, const mon_cmd_t *cmd, >> const QDict *params) >> { >> int ret; >> @@ -954,

Re: [Qemu-devel] [PATCH] monitor: suggest running "help" for command errors

2015-05-14 Thread Markus Armbruster
Bandan Das writes: > When a command fails due to incorrect syntax or input, > suggest using the "help" command to get more information > about the command. This is only applicable for HMP. > > Before: > (qemu) drive_add usb_flash_drive > drive_add: string expected > After: > (qemu) drive_add usb_

[Qemu-devel] [PATCH] monitor: suggest running "help" for command errors

2015-05-13 Thread Bandan Das
When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP. Before: (qemu) drive_add usb_flash_drive drive_add: string expected After: (qemu) drive_add usb_flash_drive drive_add: string expecte