Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Luiz Capitulino
On Mon, 20 Aug 2012 19:55:10 + Blue Swirl wrote: > On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino > wrote: > > On Sat, 18 Aug 2012 20:14:54 + > > Blue Swirl wrote: > > > >> Some variables are only used on !win32, declare > >> them only when used. > >> > >> This avoids a warning in mi

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Blue Swirl
On Mon, Aug 20, 2012 at 3:08 PM, Luiz Capitulino wrote: > On Sat, 18 Aug 2012 20:14:54 + > Blue Swirl wrote: > >> Some variables are only used on !win32, declare >> them only when used. >> >> This avoids a warning in mingw32 build: >> CCi386-softmmu/monitor.o >> /src/qemu/monitor.c: In

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-20 Thread Luiz Capitulino
On Sat, 18 Aug 2012 20:14:54 + Blue Swirl wrote: > Some variables are only used on !win32, declare > them only when used. > > This avoids a warning in mingw32 build: > CCi386-softmmu/monitor.o > /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': > /src/qemu/monitor.c:2575: warnin

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-18 Thread Stefan Weil
Am 18.08.2012 22:14, schrieb Blue Swirl: Some variables are only used on !win32, declare them only when used. This avoids a warning in mingw32 build: CCi386-softmmu/monitor.o /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': /src/qemu/monitor.c:2575: warning: unused variable 'mon_f

[Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-18 Thread Blue Swirl
Some variables are only used on !win32, declare them only when used. This avoids a warning in mingw32 build: CCi386-softmmu/monitor.o /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': /src/qemu/monitor.c:2575: warning: unused variable 'mon_fd_flags' /src/qemu/monitor.c:2574: warning: