Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-24 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 09:17:51AM +0200, Markus Armbruster wrote: > Stefan Weil writes: > > > Am 17.08.2012 17:02, schrieb Luiz Capitulino: > >> On Fri, 17 Aug 2012 16:41:34 +0200 > >> Markus Armbruster wrote: > >> > >>> Luiz Capitulino writes: > >>> > On Fri, 17 Aug 2012 16:10:12 +0200 >

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-20 Thread Markus Armbruster
Stefan Weil writes: > Am 17.08.2012 17:02, schrieb Luiz Capitulino: >> On Fri, 17 Aug 2012 16:41:34 +0200 >> Markus Armbruster wrote: >> >>> Luiz Capitulino writes: >>> On Fri, 17 Aug 2012 16:10:12 +0200 Markus Armbruster wrote: > Stefan Weil writes: > >> ccc-analyz

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-18 Thread Stefan Weil
Am 17.08.2012 17:02, schrieb Luiz Capitulino: On Fri, 17 Aug 2012 16:41:34 +0200 Markus Armbruster wrote: Luiz Capitulino writes: On Fri, 17 Aug 2012 16:10:12 +0200 Markus Armbruster wrote: Stefan Weil writes: ccc-analyzer reports these warnings: monitor.c:3532:21: warning: Division

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Luiz Capitulino
On Fri, 17 Aug 2012 16:41:34 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > On Fri, 17 Aug 2012 16:10:12 +0200 > > Markus Armbruster wrote: > > > >> Stefan Weil writes: > >> > >> > ccc-analyzer reports these warnings: > >> > > >> > monitor.c:3532:21: warning: Division by zero

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 17 Aug 2012 16:10:12 +0200 > Markus Armbruster wrote: > >> Stefan Weil writes: >> >> > ccc-analyzer reports these warnings: >> > >> > monitor.c:3532:21: warning: Division by zero >> > val %= val2; >> > ^ >> > monitor.c:3530:

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Luiz Capitulino
On Fri, 17 Aug 2012 16:10:12 +0200 Markus Armbruster wrote: > Stefan Weil writes: > > > ccc-analyzer reports these warnings: > > > > monitor.c:3532:21: warning: Division by zero > > val %= val2; > > ^ > > monitor.c:3530:21: warning: Division by zero > >

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Markus Armbruster
Stefan Weil writes: > ccc-analyzer reports these warnings: > > monitor.c:3532:21: warning: Division by zero > val %= val2; > ^ > monitor.c:3530:21: warning: Division by zero > val /= val2; > ^ > > Rewriting the code fixes thi

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Luiz Capitulino
On Fri, 17 Aug 2012 15:34:04 +0200 Stefan Weil wrote: > ccc-analyzer reports these warnings: > > monitor.c:3532:21: warning: Division by zero > val %= val2; > ^ > monitor.c:3530:21: warning: Division by zero > val /= val2; >

[Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-17 Thread Stefan Weil
ccc-analyzer reports these warnings: monitor.c:3532:21: warning: Division by zero val %= val2; ^ monitor.c:3530:21: warning: Division by zero val /= val2; ^ Rewriting the code fixes this (and also a style issue). Signed-off-