Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-09 Thread Markus Armbruster
Paolo Bonzini writes: > Il 09/04/2013 10:52, Markus Armbruster ha scritto: >>> > This also removes the need to do something special on valgrind >>> > (see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31). >> Suggest to state explicitly that you effectively revert it. >> >> You left

Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-09 Thread Juan Quintela
Paolo Bonzini wrote: > Using qemu_memalign only leaves the RAM zero by chance, because libc > will usually use mmap to satisfy our huge requests. But memory will > not be zero when using MALLOC_PERTURB_ with a nonzero value. In the > case of incoming migration, this breaks a recently-introduced

Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-09 Thread Paolo Bonzini
Il 09/04/2013 10:52, Markus Armbruster ha scritto: >> > This also removes the need to do something special on valgrind >> > (see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31). > Suggest to state explicitly that you effectively revert it. > > You left #define CONFIG_VALGRIND in, ev

Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-09 Thread Markus Armbruster
Paolo Bonzini writes: > Using qemu_memalign only leaves the RAM zero by chance, because libc > will usually use mmap to satisfy our huge requests. But memory will > not be zero when using MALLOC_PERTURB_ with a nonzero value. In the > case of incoming migration, this breaks a recently-introduce

Re: [Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-08 Thread Peter Lieven
Am 08.04.2013 um 12:47 schrieb Paolo Bonzini : > Using qemu_memalign only leaves the RAM zero by chance, because libc > will usually use mmap to satisfy our huge requests. But memory will > not be zero when using MALLOC_PERTURB_ with a nonzero value. In the > case of incoming migration, this br

[Qemu-devel] [PATCH] migration: initialize RAM to zero

2013-04-08 Thread Paolo Bonzini
Using qemu_memalign only leaves the RAM zero by chance, because libc will usually use mmap to satisfy our huge requests. But memory will not be zero when using MALLOC_PERTURB_ with a nonzero value. In the case of incoming migration, this breaks a recently-introduced invariant (commit f1c7279, mig