Re: [Qemu-devel] [PATCH] migration: fix potential overflow in multifd send

2018-07-24 Thread Eric Blake
On 07/24/2018 10:59 AM, Dr. David Alan Gilbert wrote: * Peter Xu (pet...@redhat.com) wrote: I would guess it won't happen normally, but this should ease Coverity. +++ b/migration/ram.c @@ -851,7 +851,7 @@ static void multifd_send_pages(void) p->pages->block = NULL; multifd_send_s

Re: [Qemu-devel] [PATCH] migration: fix potential overflow in multifd send

2018-07-24 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > I would guess it won't happen normally, but this should ease Coverity. > > >>> CID 1394385: Integer handling issues (OVERFLOW_BEFORE_WIDEN) > >>> Potentially overflowing expression "pages->used * 8192U" with type > >>> "unsigned int" (32 bits, uns

Re: [Qemu-devel] [PATCH] migration: fix potential overflow in multifd send

2018-07-20 Thread Juan Quintela
Peter Xu wrote: > I would guess it won't happen normally, but this should ease Coverity. > CID 1394385: Integer handling issues (OVERFLOW_BEFORE_WIDEN) Potentially overflowing expression "pages->used * 8192U" with type "unsigned int" (32 bits, unsigned) is evaluated using

[Qemu-devel] [PATCH] migration: fix potential overflow in multifd send

2018-07-19 Thread Peter Xu
I would guess it won't happen normally, but this should ease Coverity. >>> CID 1394385: Integer handling issues (OVERFLOW_BEFORE_WIDEN) >>> Potentially overflowing expression "pages->used * 8192U" with type >>> "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, >>