Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

2017-12-05 Thread Greg Kurz
On Tue, 5 Dec 2017 13:27:40 +0100 Laurent Vivier wrote: > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") > the HTAB migration stream contains a header set to "-1", meaning there > is no HPT. Teach analyze-migration.py to ignore the section in this case. > > Without

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

2017-12-05 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Tue, Dec 05, 2017 at 12:44:40PM +, Dr. David Alan Gilbert wrote: > > * Laurent Vivier (lviv...@redhat.com) wrote: > > > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration > > > stream") > > > the HTAB migration stream co

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

2017-12-05 Thread David Gibson
On Tue, Dec 05, 2017 at 12:44:40PM +, Dr. David Alan Gilbert wrote: > * Laurent Vivier (lviv...@redhat.com) wrote: > > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") > > the HTAB migration stream contains a header set to "-1", meaning there > > is no HPT. Teach ana

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

2017-12-05 Thread Dr. David Alan Gilbert
* Laurent Vivier (lviv...@redhat.com) wrote: > Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") > the HTAB migration stream contains a header set to "-1", meaning there > is no HPT. Teach analyze-migration.py to ignore the section in this case. > > Without this fix, the

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script with radix table

2017-12-05 Thread Laurent Vivier
Since commit 3a38429748 ("Add a "no HPT" encoding to HTAB migration stream") the HTAB migration stream contains a header set to "-1", meaning there is no HPT. Teach analyze-migration.py to ignore the section in this case. Without this fix, the script fails with a dump from a POWER9 guest: Traceba

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-11-26 Thread Juan Quintela
Alexander Graf wrote: > On 26.11.15 16:31, Dr. David Alan Gilbert wrote: >> * Alexander Graf (ag...@suse.de) wrote: >>> >>> >>> On 30.10.15 17:50, Mark Cave-Ayland wrote: On 26/10/15 09:48, Mark Cave-Ayland wrote: > On 06/09/15 12:54, Mark Cave-Ayland wrote: > >> On 06/09/15

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-11-26 Thread Alexander Graf
On 26.11.15 16:31, Dr. David Alan Gilbert wrote: > * Alexander Graf (ag...@suse.de) wrote: >> >> >> On 30.10.15 17:50, Mark Cave-Ayland wrote: >>> On 26/10/15 09:48, Mark Cave-Ayland wrote: >>> On 06/09/15 12:54, Mark Cave-Ayland wrote: > On 06/09/15 09:36, Alexander Graf wrote: >>>

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-11-26 Thread Dr. David Alan Gilbert
* Alexander Graf (ag...@suse.de) wrote: > > > On 30.10.15 17:50, Mark Cave-Ayland wrote: > > On 26/10/15 09:48, Mark Cave-Ayland wrote: > > > >> On 06/09/15 12:54, Mark Cave-Ayland wrote: > >> > >>> On 06/09/15 09:36, Alexander Graf wrote: > >>> > On 05.09.15 21:51, Mark Cave-Ayland wrote:

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-11-26 Thread Alexander Graf
On 30.10.15 17:50, Mark Cave-Ayland wrote: > On 26/10/15 09:48, Mark Cave-Ayland wrote: > >> On 06/09/15 12:54, Mark Cave-Ayland wrote: >> >>> On 06/09/15 09:36, Alexander Graf wrote: >>> On 05.09.15 21:51, Mark Cave-Ayland wrote: > Commit 61964 "Add configuration section" broke the ana

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-10-30 Thread Mark Cave-Ayland
On 26/10/15 09:48, Mark Cave-Ayland wrote: > On 06/09/15 12:54, Mark Cave-Ayland wrote: > >> On 06/09/15 09:36, Alexander Graf wrote: >> >>> On 05.09.15 21:51, Mark Cave-Ayland wrote: Commit 61964 "Add configuration section" broke the analyze-migration.py script which terminates d

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-10-26 Thread Mark Cave-Ayland
On 06/09/15 12:54, Mark Cave-Ayland wrote: > On 06/09/15 09:36, Alexander Graf wrote: > >> On 05.09.15 21:51, Mark Cave-Ayland wrote: >>> Commit 61964 "Add configuration section" broke the analyze-migration.py >>> script >>> which terminates due to the unrecognised section. Fix the script by par

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-06 Thread Mark Cave-Ayland
On 06/09/15 09:36, Alexander Graf wrote: > On 05.09.15 21:51, Mark Cave-Ayland wrote: >> Commit 61964 "Add configuration section" broke the analyze-migration.py >> script >> which terminates due to the unrecognised section. Fix the script by parsing >> the contents of the configuration section di

Re: [Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-06 Thread Alexander Graf
On 05.09.15 21:51, Mark Cave-Ayland wrote: > Commit 61964 "Add configuration section" broke the analyze-migration.py script > which terminates due to the unrecognised section. Fix the script by parsing > the contents of the configuration section directly into a new > ConfigurationSection object (

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-05 Thread Mark Cave-Ayland
Whilst investigating a migration issue, I noticed that the analyze-migration.py script had accidentally been broken by commit 61964. I've implemented a quick workaround to parse the configuration section into a separate Python object, however the solution works by parsing the SaveState properties

[Qemu-devel] [PATCH] migration: fix analyze-migration.py script

2015-09-05 Thread Mark Cave-Ayland
Commit 61964 "Add configuration section" broke the analyze-migration.py script which terminates due to the unrecognised section. Fix the script by parsing the contents of the configuration section directly into a new ConfigurationSection object (although nothing is done with it yet). Signed-off-by