Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-15 Thread Halil Pasic
On 02/15/2017 12:46 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote: >>> On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote: * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > The member VM

Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-15 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > > > On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote: > > On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote: > >> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > >>> The member VMStateField.start is used for two things, partial data > >>>

Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-15 Thread Halil Pasic
On 02/11/2017 05:26 AM, Philippe Mathieu-Daudé wrote: > On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote: >> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >>> The member VMStateField.start is used for two things, partial data >>> migration for VBUFFER data (basically provide migration for a

Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-10 Thread Philippe Mathieu-Daudé
On 02/10/2017 12:24 PM, Dr. David Alan Gilbert wrote: * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: The member VMStateField.start is used for two things, partial data migration for VBUFFER data (basically provide migration for a sub-buffer) and for locating next in QTAILQ. The implementation

Re: [Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-10 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > The member VMStateField.start is used for two things, partial data > migration for VBUFFER data (basically provide migration for a > sub-buffer) and for locating next in QTAILQ. > > The implementation of the VBUFFER feature is broken when VMSTATE_A

[Qemu-devel] [PATCH] migration: consolidate VMStateField.start

2017-02-03 Thread Halil Pasic
The member VMStateField.start is used for two things, partial data migration for VBUFFER data (basically provide migration for a sub-buffer) and for locating next in QTAILQ. The implementation of the VBUFFER feature is broken when VMSTATE_ALLOC is used. This however goes unnoticed because actually