Re: [Qemu-devel] [PATCH] migration: comment VMSTATE_UNUSED*() properly

2019-05-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It is error prone to use VMSTATE_UNUSED*() sometimes especially when > the size of the migration stream of the field is not the same as the > size of the structure (boolean is one example). Comment it well so > people will be aware of this when people want t

Re: [Qemu-devel] [PATCH] migration: comment VMSTATE_UNUSED*() properly

2019-03-29 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > It is error prone to use VMSTATE_UNUSED*() sometimes especially when > the size of the migration stream of the field is not the same as the > size of the structure (boolean is one example). Comment it well so > people will be aware of this when people want t

[Qemu-devel] [PATCH] migration: comment VMSTATE_UNUSED*() properly

2019-03-29 Thread Peter Xu
It is error prone to use VMSTATE_UNUSED*() sometimes especially when the size of the migration stream of the field is not the same as the size of the structure (boolean is one example). Comment it well so people will be aware of this when people want to use it. Signed-off-by: Peter Xu --- inclu