Re: [Qemu-devel] [PATCH] migration: add more traces

2014-03-03 Thread Paolo Bonzini
Good idea, but I dislike the generic trace_migrate_event tracepoint. Better add separate generic tracepoints, for example: @@ -111,7 +101,7 @@ static void process_incoming_migration_co(void *opaque) exit(EXIT_FAILURE); } qemu_announce_self(); -DPRINTF("successfully loaded

Re: [Qemu-devel] [PATCH] migration: add more traces

2014-03-02 Thread 陈梁
I am glad to hear that you are also interested in migration. We will be pleasure if you find some bugs or suggestion and discuss them together with us. As I know, the qemu will print some log about the migration failure. It is same to your patch. > This adds more traces in the migration code. >

[Qemu-devel] [PATCH] migration: add more traces

2014-03-02 Thread Alexey Kardashevskiy
This adds more traces in the migration code. Signed-off-by: Alexey Kardashevskiy --- Debugging migration lately a lot and this patch helps quite a lot. Would it make any use for anyone else? Thanks. --- migration.c | 34 +++--- savevm.c | 14 -- tr