Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-18 Thread Stefan Hajnoczi
On Thu, Jul 12, 2018 at 11:02:08PM +0800, Peng Tao wrote: > On Tue, Jul 10, 2018 at 9:40 PM, Stefan Hajnoczi wrote: > > Two things come to mind: > > > > At that point both guest kernel and agent address-space layout > > randomization (ASLR) is finished. ALSR makes it harder for memory > > corrupt

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-12 Thread Peng Tao
Hi Stefan, On Tue, Jul 10, 2018 at 9:40 PM, Stefan Hajnoczi wrote: > Two things come to mind: > > At that point both guest kernel and agent address-space layout > randomization (ASLR) is finished. ALSR makes it harder for memory > corruption bugs to lead to real exploits because the attacker doe

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-10 Thread Stefan Hajnoczi
On Tue, Jul 03, 2018 at 11:10:12PM +0800, Peng Tao wrote: > On Tue, Jul 3, 2018 at 6:05 PM, Stefan Hajnoczi wrote: > > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: > >> On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: > >> > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangsh

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-03 Thread Peng Tao
On Tue, Jul 3, 2018 at 6:05 PM, Stefan Hajnoczi wrote: > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: >> On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: >> > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote: >> > Risks: >> > 1. If one cloned VM is exploited then a

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-03 Thread Stefan Hajnoczi
On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: > On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: > > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote: > > Risks: > > 1. If one cloned VM is exploited then all other VMs are more likely to > >be exploitable (e.g. ke

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Peng Tao
On Tue, Jul 3, 2018 at 6:15 AM, Andrea Arcangeli wrote: > Hello, > > On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: >> I think we can write some host generated random seeds to guest's >> urandom device, when cloning VMs from the same template before handing >> it to users. Is it enough

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Andrea Arcangeli
Hello, On Mon, Jul 02, 2018 at 09:52:08PM +0800, Peng Tao wrote: > I think we can write some host generated random seeds to guest's > urandom device, when cloning VMs from the same template before handing > it to users. Is it enough or do you think there are more to do w/ > re-randomizing? That m

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Andrea Arcangeli
Hello everyone, On Mon, Jul 02, 2018 at 02:10:54PM +0100, Stefan Hajnoczi wrote: > Marcelo, Andrea, Paolo: There was a more complex local migration > approach in 2013 with fd passing and vmsplice. They specifically > avoided the approach proposed in this patch, but I don't remember why. > > The

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Peng Tao
On Mon, Jul 2, 2018 at 9:10 PM, Stefan Hajnoczi wrote: > On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote: >> a) feature: qemu-local-migration, qemu-live-update >> Set the mem-path on the tmpfs and set share=on for it when >> start the vm. example: >> -object \ >> memory-backend-file,

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-07-02 Thread Stefan Hajnoczi
On Sat, Mar 31, 2018 at 04:45:00PM +0800, Lai Jiangshan wrote: > a) feature: qemu-local-migration, qemu-live-update > Set the mem-path on the tmpfs and set share=on for it when > start the vm. example: > -object \ > memory-backend-file,id=mem,size=128M,mem-path=/dev/shm/memory,share=on \ > -numa no

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-03-31 Thread Eric Blake
On 03/31/2018 03:45 AM, Lai Jiangshan wrote: 1) What's this When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, ex

[Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-03-31 Thread Lai Jiangshan
1) What's this When the migration capability 'bypass-shared-memory' is set, the shared memory will be bypassed when migration. It is the key feature to enable several excellent features for the qemu, such as qemu-local-migration, qemu-live-update, extremely-fast-save-restore, vm-template, vm-fast

Re: [Qemu-devel] [PATCH] migration: add capability to bypass the shared memory

2018-03-31 Thread Lai Jiangshan
The attached patch is based on v2.11.1. It was pushed on https://github.com/hyperhq/qemu v2.11.1-template The updated patch for upstream qemu is on https://github.com/hyperhq/qemu upstream-template On Sat, Mar 31, 2018 at 4:45 PM, Lai Jiangshan wrote: > --- > migration/migration.c | 13 +