Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Paolo Bonzini
Il 28/03/2014 12:30, Dr. David Alan Gilbert ha scritto: > Another reason for doing it in libvirt is that the serialization > between cancellation and completion of migration ultimately is > controlled by libvirt's lock. Doing this in QEMU makes it harder to > reason about concurrency. I think y

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > Il 28/03/2014 10:18, Gonglei (Arei) ha scritto: > >>> > Can you please give more details at how you are triggering the problem > >>> > with libvirt? I think Paolo is probably right - the bug is more likely > >>> > to be in libvirt not expecting the ra

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Paolo Bonzini
Il 28/03/2014 10:18, Gonglei (Arei) ha scritto: > > Can you please give more details at how you are triggering the problem > > with libvirt? I think Paolo is probably right - the bug is more likely > > to be in libvirt not expecting the race and not recovering correctly > > when the race occurs,

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-28 Thread Gonglei (Arei)
> > >> Return error for migrate cancel, when migration status is not > > >> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can > > >> perceive the operation fails. > > >> > > >> Signed-off-by: zengjunliang > > >> Signed-off-by: Gonglei > > > > > > I think this is done on purpose, because

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-25 Thread Gonglei (Arei)
> -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, March 25, 2014 12:01 AM > To: Paolo Bonzini; Gonglei (Arei); qemu-devel@nongnu.org > Cc: quint...@redhat.com; owass...@redhat.com; Yanqiangjun; Zhaoyanbin > (A); Zengjunliang; libvir-l...@redhat.com > Subjec

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread Eric Blake
[adding libvirt] On 03/24/2014 09:47 AM, Paolo Bonzini wrote: > Il 24/03/2014 14:04, arei.gong...@huawei.com ha scritto: >> From: zengjunliang >> >> Return error for migrate cancel, when migration status is not >> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can >> perceive the operatio

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread Paolo Bonzini
Il 24/03/2014 14:04, arei.gong...@huawei.com ha scritto: From: zengjunliang Return error for migrate cancel, when migration status is not MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can perceive the operation fails. Signed-off-by: zengjunliang Signed-off-by: Gonglei I think this

Re: [Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread Eric Blake
On 03/24/2014 07:04 AM, arei.gong...@huawei.com wrote: > From: zengjunliang > > Return error for migrate cancel, when migration status is not > MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can > perceive the operation fails. > > Signed-off-by: zengjunliang > Signed-off-by: Gonglei >

[Qemu-devel] [PATCH] migration: Fix possible bug for migrate cancel

2014-03-24 Thread arei.gonglei
From: zengjunliang Return error for migrate cancel, when migration status is not MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can perceive the operation fails. Signed-off-by: zengjunliang Signed-off-by: Gonglei --- include/qapi/qmp/qerror.h | 3 +++ migration.c | 5 +++