Michael Tokarev wrote:
> Do not check for rdma->host being empty twice. This removes a large
> "if" block, so code indentation is changed. While at it, remove an
> ugly goto from the loop, replacing it with a cleaner if logic. And
> finally, there's no need to initialize `ret' variable since is
04.03.2015 16:32, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (m...@tls.msk.ru) wrote:
[]
>> I think it's okay to merge it using the -trivial tree, I'm about to
>> send a pull request today.
>
> Yes, OK, although I'd generally prefer the RDMA stuff to go
> through migration unless it's reall
* Michael Tokarev (m...@tls.msk.ru) wrote:
> 04.03.2015 15:16, Dr. David Alan Gilbert wrote:
> > * Michael Tokarev (m...@tls.msk.ru) wrote:
> >> Do not check for rdma->host being empty twice. This removes a large
> >> "if" block, so code indentation is changed. While at it, remove an
> >> ugly go
04.03.2015 15:16, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (m...@tls.msk.ru) wrote:
>> Do not check for rdma->host being empty twice. This removes a large
>> "if" block, so code indentation is changed. While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logi
* Michael Tokarev (m...@tls.msk.ru) wrote:
> Do not check for rdma->host being empty twice. This removes a large
> "if" block, so code indentation is changed. While at it, remove an
> ugly goto from the loop, replacing it with a cleaner if logic. And
> finally, there's no need to initialize `ret
19.02.2015 13:25, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (m...@tls.msk.ru) wrote:
>> Do not check for rdma->host being empty twice. This removes a large
>> "if" block, so code indentation is changed. While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logi
* Michael Tokarev (m...@tls.msk.ru) wrote:
> Do not check for rdma->host being empty twice. This removes a large
> "if" block, so code indentation is changed. While at it, remove an
> ugly goto from the loop, replacing it with a cleaner if logic. And
> finally, there's no need to initialize `ret
Do not check for rdma->host being empty twice. This removes a large
"if" block, so code indentation is changed. While at it, remove an
ugly goto from the loop, replacing it with a cleaner if logic. And
finally, there's no need to initialize `ret' variable since is always
has a value.
Signed-off
