Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-03-05 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > If the migration fails before the channel is open (e.g. a bad > address) we end up in the cleanup with rdma->channel==NULL. > > Spotted by Coverity: CID 1398634 > Fixes: fbbaacab2758cb3f32a0 > Signed

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-15 Thread Peter Xu
On Fri, Feb 15, 2019 at 11:00:56AM +, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Feb 14, 2019 at 06:53:51PM +, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > If the migration fails before the channel is open

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-15 Thread Philippe Mathieu-Daudé
On 2/14/19 7:53 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the migration fails before the channel is open (e.g. a bad > address) we end up in the cleanup with rdma->channel==NULL. > > Spotted by Coverity: CID 1398634 > Fixes: fbbaacab2758cb3f32a0 > Signed-off

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-15 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Feb 14, 2019 at 06:53:51PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > If the migration fails before the channel is open (e.g. a bad > > address) we end up in the cleanup with rdma->channel==NULL. > > > > S

Re: [Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-14 Thread Peter Xu
On Thu, Feb 14, 2019 at 06:53:51PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > If the migration fails before the channel is open (e.g. a bad > address) we end up in the cleanup with rdma->channel==NULL. > > Spotted by Coverity: CID 1398634 > Fixes: fbbaacab275

[Qemu-devel] [PATCH] migration/rdma: Fix qemu_rdma_cleanup null check

2019-02-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If the migration fails before the channel is open (e.g. a bad address) we end up in the cleanup with rdma->channel==NULL. Spotted by Coverity: CID 1398634 Fixes: fbbaacab2758cb3f32a0 Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 4 +++- 1 file chan