Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-05-01 Thread John Snow
On 5/1/19 11:24 AM, Eric Blake wrote: > On 4/30/19 6:08 PM, John Snow wrote: >> >> >> On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 16.11.2018 21:43, John Snow wrote: Coverity warns that backing_bs() could give us a NULL pointer, which we then use without checking that

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-05-01 Thread Eric Blake
On 4/30/19 6:08 PM, John Snow wrote: > > > On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: >> 16.11.2018 21:43, John Snow wrote: >>> Coverity warns that backing_bs() could give us a NULL pointer, which >>> we then use without checking that it isn't. >>> >>> In our loop condition, we che

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-04-30 Thread John Snow
On 11/20/18 10:15 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2018 21:43, John Snow wrote: >> Coverity warns that backing_bs() could give us a NULL pointer, which >> we then use without checking that it isn't. >> >> In our loop condition, we check bs && bs->drv as a point of habit, but >> by

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2019-03-26 Thread Peter Maydell
On Fri, 16 Nov 2018 at 18:43, John Snow wrote: > > Coverity warns that backing_bs() could give us a NULL pointer, which > we then use without checking that it isn't. > > In our loop condition, we check bs && bs->drv as a point of habit, but > by nature of the block graph, we cannot have null bs po

Re: [Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2018-11-20 Thread Vladimir Sementsov-Ogievskiy
16.11.2018 21:43, John Snow wrote: > Coverity warns that backing_bs() could give us a NULL pointer, which > we then use without checking that it isn't. > > In our loop condition, we check bs && bs->drv as a point of habit, but > by nature of the block graph, we cannot have null bs pointers here. >

[Qemu-devel] [PATCH] migration/block-dirty-bitmap: Silence coverity CID 1390625

2018-11-16 Thread John Snow
Coverity warns that backing_bs() could give us a NULL pointer, which we then use without checking that it isn't. In our loop condition, we check bs && bs->drv as a point of habit, but by nature of the block graph, we cannot have null bs pointers here. This loop skips only implicit nodes, which al