Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Eric Blake
On 03/07/2014 08:13 AM, Marcelo Tosatti wrote: > On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote: >> On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: >>> >>> Failing initialization in case hugepage path has >>> hugepage smaller than specified. >>> >>> Signed-off-by: Marcelo Tosatti >>> >

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Marcelo Tosatti
On Fri, Mar 07, 2014 at 08:53:50AM +0100, Paolo Bonzini wrote: > Il 07/03/2014 01:40, Marcelo Tosatti ha scritto: > > > >Failing initialization in case hugepage path has > >hugepage smaller than specified. > > > >Signed-off-by: Marcelo Tosatti > > > Why is this needed? Isn't it just operator er

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-07 Thread Marcelo Tosatti
On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote: > On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: > > > > Failing initialization in case hugepage path has > > hugepage smaller than specified. > > > > Signed-off-by: Marcelo Tosatti > > > > diff --git a/exec.c b/exec.c > > index b69fd

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-06 Thread Paolo Bonzini
Il 07/03/2014 01:40, Marcelo Tosatti ha scritto: Failing initialization in case hugepage path has hugepage smaller than specified. Signed-off-by: Marcelo Tosatti Why is this needed? Isn't it just operator error? Perhaps libvirt could add an attribute to its XML element, and could use it

Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-06 Thread Eric Blake
On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: > > Failing initialization in case hugepage path has > hugepage smaller than specified. > > Signed-off-by: Marcelo Tosatti > > diff --git a/exec.c b/exec.c > index b69fd29..c95a0f3 100644 > --- a/exec.c > +++ b/exec.c > }; > > +static QemuOpts

[Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size

2014-03-06 Thread Marcelo Tosatti
Failing initialization in case hugepage path has hugepage smaller than specified. Signed-off-by: Marcelo Tosatti diff --git a/exec.c b/exec.c index b69fd29..c95a0f3 100644 --- a/exec.c +++ b/exec.c @@ -1034,6 +1034,13 @@ static void *file_ram_alloc(RAMBlock *block, return NULL; }